Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755026AbZDUJzp (ORCPT ); Tue, 21 Apr 2009 05:55:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753045AbZDUJzf (ORCPT ); Tue, 21 Apr 2009 05:55:35 -0400 Received: from mail-bw0-f163.google.com ([209.85.218.163]:54463 "EHLO mail-bw0-f163.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750850AbZDUJze (ORCPT ); Tue, 21 Apr 2009 05:55:34 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=p0eRB76XFiR/Fy6Fxa3ZOlpb5zkftfo9JRrdIYcMB0OIlGoX0cdCRY5gJhSmFm1NPZ H6sKe/0uI4OnPt/C2dFcfkRLiSE1GOEXeyVl5AhvScG5IFoigteqzByUcWPpv7oARQez bKwPo4jb2l2zvEP67587qZCcduxywDOtEiIDs= Date: Tue, 21 Apr 2009 11:55:26 +0200 From: Andrea Righi To: KAMEZAWA Hiroyuki Cc: Paul Menage , Balbir Singh , Gui Jianfeng , agk@sourceware.org, akpm@linux-foundation.org, axboe@kernel.dk, baramsori72@gmail.com, Carl Henrik Lunde , dave@linux.vnet.ibm.com, Divyesh Shah , eric.rannaud@gmail.com, fernando@oss.ntt.co.jp, Hirokazu Takahashi , Li Zefan , matt@bluehost.com, dradford@bluehost.com, ngupta@google.com, randy.dunlap@oracle.com, roberto@unbit.it, Ryo Tsuruta , Satoshi UCHIDA , subrata@linux.vnet.ibm.com, yoshikawa.takuya@oss.ntt.co.jp, Nauman Rafique , fchecconi@gmail.com, paolo.valente@unimore.it, containers@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/7] res_counter: introduce ratelimiting attributes Message-ID: <20090421095525.GA13699@linux> References: <1240090712-1058-1-git-send-email-righi.andrea@gmail.com> <1240090712-1058-3-git-send-email-righi.andrea@gmail.com> <20090421091534.971f676f.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090421091534.971f676f.kamezawa.hiroyu@jp.fujitsu.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4178 Lines: 105 On Tue, Apr 21, 2009 at 09:15:34AM +0900, KAMEZAWA Hiroyuki wrote: > On Sat, 18 Apr 2009 23:38:27 +0200 > Andrea Righi wrote: > > > Introduce attributes and functions in res_counter to implement throttling-based > > cgroup subsystems. > > > > The following attributes have been added to struct res_counter: > > * @policy: the limiting policy / algorithm > > * @capacity: the maximum capacity of the resource > > * @timestamp: timestamp of the last accounted resource request > > > > Currently the available policies are: token-bucket and leaky-bucket and the > > attribute @capacity is only used by token-bucket policy (to represent the > > bucket size). > > > > The following function has been implemented to return the amount of time a > > cgroup should sleep to remain within the defined resource limits. > > > > unsigned long long > > res_counter_ratelimit_sleep(struct res_counter *res, ssize_t val); > > > > [ Note: only the interfaces needed by the cgroup IO controller are implemented > > right now ] > > > > Signed-off-by: Andrea Righi > > --- > > include/linux/res_counter.h | 69 +++++++++++++++++++++++++++++++---------- > > kernel/res_counter.c | 72 +++++++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 124 insertions(+), 17 deletions(-) > > > > diff --git a/include/linux/res_counter.h b/include/linux/res_counter.h > > index 4c5bcf6..9bed6af 100644 > > --- a/include/linux/res_counter.h > > +++ b/include/linux/res_counter.h > > @@ -14,30 +14,36 @@ > > */ > > > > #include > > +#include > > > > -/* > > - * The core object. the cgroup that wishes to account for some > > - * resource may include this counter into its structures and use > > - * the helpers described beyond > > - */ > > +/* The various policies that can be used for ratelimiting resources */ > > +#define RATELIMIT_LEAKY_BUCKET 0 > > +#define RATELIMIT_TOKEN_BUCKET 1 > > > > +/** > > + * struct res_counter - the core object to account cgroup resources > > + * > > + * @usage: the current resource consumption level > > + * @max_usage: the maximal value of the usage from the counter creation > > + * @limit: the limit that usage cannot be exceeded > > + * @failcnt: the number of unsuccessful attempts to consume the resource > > + * @policy: the limiting policy / algorithm > > + * @capacity: the maximum capacity of the resource > > + * @timestamp: timestamp of the last accounted resource request > > + * @lock: the lock to protect all of the above. > > + * The routines below consider this to be IRQ-safe > > + * > > + * The cgroup that wishes to account for some resource may include this counter > > + * into its structures and use the helpers described beyond. > > + */ > > struct res_counter { > > - /* > > - * the current resource consumption level > > - */ > > unsigned long long usage; > > - /* > > - * the maximal value of the usage from the counter creation > > - */ > > unsigned long long max_usage; > > - /* > > - * the limit that usage cannot exceed > > - */ > > unsigned long long limit; > > - /* > > - * the number of unsuccessful attempts to consume the resource > > - */ > > unsigned long long failcnt; > > + unsigned long long policy; > > + unsigned long long capacity; > > + unsigned long long timestamp; > > > Andrea, sizeof(struct res_counter) is getting close to 128bytes. (maybe someone adds more) > Then, could you check "unsigned long or unsigned int" is allowed or not, again ? > > It's very bad if cacheline of spinlock is different from data field, in future. Regarding the new attributes, policy can be surely an unsigned int or even less (now only 1 bit is used!), maybe we can just add an unsigned int flags, and encode also potential future informations there. Moreover, are we sure we really need an unsigned long long for failcnt? Thanks, -Andrea -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/