Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754247AbZDUKGX (ORCPT ); Tue, 21 Apr 2009 06:06:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751644AbZDUKGI (ORCPT ); Tue, 21 Apr 2009 06:06:08 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:57128 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751137AbZDUKGH (ORCPT ); Tue, 21 Apr 2009 06:06:07 -0400 Message-ID: <49ED9AC2.9000507@cn.fujitsu.com> Date: Tue, 21 Apr 2009 18:06:58 +0800 From: Li Zefan User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Ingo Molnar CC: Tom Zanussi , Steven Rostedt , Frederic Weisbecker , LKML Subject: Re: [PATCH 3/3] tracing/filters: disallow newline as delimeter References: <49ED8DD2.2070700@cn.fujitsu.com> <49ED8DFD.9070909@cn.fujitsu.com> <20090421095705.GA15448@elte.hu> In-Reply-To: <20090421095705.GA15448@elte.hu> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 822 Lines: 35 Ingo Molnar wrote: > * Li Zefan wrote: > >> I guess because user input is often ended with '\n' (like "echo >> xxx"), thus '\n' is used as a delimeter besides ' ', but we can >> just strip tailing spaces. > > Hm, how about: > > ( echo 'x' > echo '|| y' ) > filter > > type of scripts? Shouldnt the parser be permissive in general? > This patch doesn't forbid this usage: ;) ( echo 'parent_comm == a' echo '|| parent_comm == b' ) > filter This patch does forbid this usage: ( echo 'parent_comm' echo '==' echo 'a' ) > filter -- Zefan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/