Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755907AbZDUKQf (ORCPT ); Tue, 21 Apr 2009 06:16:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753312AbZDUKQ0 (ORCPT ); Tue, 21 Apr 2009 06:16:26 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:46209 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754332AbZDUKQZ (ORCPT ); Tue, 21 Apr 2009 06:16:25 -0400 Date: Tue, 21 Apr 2009 12:16:19 +0200 From: Ingo Molnar To: Li Zefan Cc: Tom Zanussi , Steven Rostedt , Frederic Weisbecker , LKML Subject: Re: [PATCH 3/3] tracing/filters: disallow newline as delimeter Message-ID: <20090421101619.GA19660@elte.hu> References: <49ED8DD2.2070700@cn.fujitsu.com> <49ED8DFD.9070909@cn.fujitsu.com> <20090421095705.GA15448@elte.hu> <49ED9AC2.9000507@cn.fujitsu.com> <20090421100722.GA18486@elte.hu> <49ED9C91.4070201@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49ED9C91.4070201@cn.fujitsu.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1287 Lines: 45 * Li Zefan wrote: > Ingo Molnar wrote: > > * Li Zefan wrote: > > > >> Ingo Molnar wrote: > >>> * Li Zefan wrote: > >>> > >>>> I guess because user input is often ended with '\n' (like "echo > >>>> xxx"), thus '\n' is used as a delimeter besides ' ', but we can > >>>> just strip tailing spaces. > >>> Hm, how about: > >>> > >>> ( echo 'x' > >>> echo '|| y' ) > filter > >>> > >>> type of scripts? Shouldnt the parser be permissive in general? > >>> > >> This patch doesn't forbid this usage: ;) > >> > >> ( echo 'parent_comm == a' > >> echo '|| parent_comm == b' ) > filter > >> > >> This patch does forbid this usage: > >> > >> ( echo 'parent_comm' > >> echo '==' > >> echo 'a' ) > filter > > > > Same argument though, no? > > > > Then I have no strong opinion on this. I'm fine to drop this patch. I've applied the other two - no strong opinion either about this patch. Tom, what do you think? (there's also some new parser in the works i suspect) Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/