Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755181AbZDVD7t (ORCPT ); Tue, 21 Apr 2009 23:59:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752879AbZDVD7j (ORCPT ); Tue, 21 Apr 2009 23:59:39 -0400 Received: from bilbo.ozlabs.org ([203.10.76.25]:50191 "EHLO bilbo.ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752665AbZDVD7i (ORCPT ); Tue, 21 Apr 2009 23:59:38 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18926.38431.910952.630575@cargo.ozlabs.ibm.com> Date: Wed, 22 Apr 2009 13:59:27 +1000 From: Paul Mackerras To: Bartlomiej Zolnierkiewicz Cc: subrata@linux.vnet.ibm.com, "Linuxppc-dev" , Benjamin Herrenschmidt , Stefan Bader , Marcelo Tosatti , Adrian Bunk , Stephen Rothwell , "linux-next" , sachinp , "linux-kernel" , Alexander Beregalov Subject: Re: [BUILD FAILURE 05/12] Next April 21 : PPC64 randconfig [drivers/macintosh/mediabay.o] In-Reply-To: <200904212104.14665.bzolnier@gmail.com> References: <1240339875.9110.137.camel@subratamodak.linux.ibm.com> <200904212104.14665.bzolnier@gmail.com> X-Mailer: VM 8.0.9 under Emacs 22.2.1 (i486-pc-linux-gnu) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 719 Lines: 18 Bartlomiej Zolnierkiewicz writes: > mediabay shouldn't include unconditionally so > remove the superfluous include from mediabay.c ( > will pull in for CONFIG_BLK_DEV_IDE_PMAC=y). I don't like relying on second-hand imports like that. I prefer the previous patch, that made mediabay depend on CONFIG_BLOCK. BTW, if including causes an error when CONFIG_BLOCK=n, then there is a bug in , IMO. Paul. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/