Date: Tue, 21 Apr 2009 22:45:31 -0700
From: Greg KH <greg@kroah.com>
To: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, gregkh@suse.de,
       kay.sievers@vrfy.org
Subject: Re: [PATCH 0/4] fix some improper uses of dev_set_name
Message-ID: <20090422054531.GD9009@kroah.com>
References: <1240273036-5995-1-git-send-email-cascardo@holoscopio.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1240273036-5995-1-git-send-email-cascardo@holoscopio.com>
User-Agent: Mutt/1.5.19 (2009-01-05)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1279
Lines: 29

On Mon, Apr 20, 2009 at 09:17:12PM -0300, Thadeu Lima de Souza Cascardo wrote:
> dev_set_name expects a format string. Many of its uses, however, blindly
> call it with a string variable that comes from some external, perhaps
> unreliable source. Some of those uses are safe, like those in the third
> patch in the series and most of those not fixed by any of them. Some few
> remaining uses may require some more attention to decide if a patch is
> really required. Perhaps converting all of them for safeness is a good
> compromise.
> 
> Thadeu Lima de Souza Cascardo (4):
>   driver core: use string format when name is another device's name
>   driver core: use string format when name is given to an exported
>     function

These two patches were a bit more than just the "driver core".  Care to
split them up into the subsystem-proper sections and send them to the
different subsystem maintainers?

I don't see anything here that can come from a user supplied string, do
you?  So it's a pretty low priority.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/