Date: Wed, 22 Apr 2009 00:44:32 -0700 (PDT)
Message-Id: <20090422.004432.227765146.davem@davemloft.net>
To: dada1@cosmosbay.com
Cc: jianjun@zeuux.org, jon.lin@vatics.com, netdev@vger.kernel.org,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.29.1 1/1] 8139too: fix HW initial flow
From: David Miller <davem@davemloft.net>
In-Reply-To: <49EDA040.5040600@cosmosbay.com>
References: <20090421.015235.23457775.davem@davemloft.net>
	<20090421094825.GA6752@ubuntu>
	<49EDA040.5040600@cosmosbay.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1193
Lines: 27

From: Eric Dumazet <dada1@cosmosbay.com>
Date: Tue, 21 Apr 2009 12:30:24 +0200

> Amos Kong a ?crit :
>> ...
>>  While ifconfig eth0 up kernel calls open() of 8139 driver(8139too.c).
>>  In rtl8139_hw_start() of rtl8139_open(), 8139 driver enable RX before setting up the DMA
>>  buffer address. In this interval where RX was enabled and DMA buffer address is not yet set
>>  up, any incoming broadcast packet would be send to a strange physical address:
>>  0x003e8800 which is the default value of DMA buffer address.
>>  Unfortunately, this address is used by Linux kernel. So kernel panics.
>>  This patch fix it by setting up DMA buffer address before RX enabled and everything is fine
>>  even under broadcast packets attack.
>> 
>> Signed-off-by: Jonathan Lin <jon.lin@vatics.com>
>> Signed-off-by: Amos Kong <jianjun@zeuux.org>
> 
> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
> 
> Thanks Amos and Jonathan

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/