Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755388AbZDVUfG (ORCPT ); Wed, 22 Apr 2009 16:35:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754977AbZDVUew (ORCPT ); Wed, 22 Apr 2009 16:34:52 -0400 Received: from mail3.caviumnetworks.com ([12.108.191.235]:12143 "EHLO mail3.caviumnetworks.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751688AbZDVUev (ORCPT ); Wed, 22 Apr 2009 16:34:51 -0400 Message-ID: <49EF7F34.9040401@caviumnetworks.com> Date: Wed, 22 Apr 2009 13:33:56 -0700 From: David Daney User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: coly.li@suse.de CC: LKML , Ingo Molnar Subject: Re: [PATCH 5/7] mips cavium-octeon: add parameter to octeon_cvmcount_read() References: <49EF6A9E.6080605@suse.de> In-Reply-To: <49EF6A9E.6080605@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 22 Apr 2009 20:33:56.0937 (UTC) FILETIME=[A8F58B90:01C9C389] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1200 Lines: 38 Coly Li wrote: > This patch modifies parameter of octeon_cvmcount_read() from 'void' to 'struct > clocksource *cs', which fixes compile warning for incompatible parameter type. > > Signed-off-by: Coly Li > Cc: David Daney > Cc: Ingo Molnar It looks good to me: Reviewed-by: David Daney > --- > arch/mips/cavium-octeon/csrc-octeon.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/mips/cavium-octeon/csrc-octeon.c > b/arch/mips/cavium-octeon/csrc-octeon.c > index 70fd92c..96110f2 100644 > --- a/arch/mips/cavium-octeon/csrc-octeon.c > +++ b/arch/mips/cavium-octeon/csrc-octeon.c > @@ -38,7 +38,7 @@ void octeon_init_cvmcount(void) > local_irq_restore(flags); > } > > -static cycle_t octeon_cvmcount_read(void) > +static cycle_t octeon_cvmcount_read(struct clocksource *cs) > { > return read_c0_cvmcount(); > } > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/