Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754730AbZDVWzp (ORCPT ); Wed, 22 Apr 2009 18:55:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751941AbZDVWzS (ORCPT ); Wed, 22 Apr 2009 18:55:18 -0400 Received: from rv-out-0506.google.com ([209.85.198.232]:44291 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751524AbZDVWzR (ORCPT ); Wed, 22 Apr 2009 18:55:17 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:message-id; b=aGpwxDE8hs4ssS0AzXjPv/EYiS5H07/FCZqR1g53jBA1GqmKVOyOIr/7ojxDsSIHoy cgoEYZMTvjsDgLto3ShqzcBqRmlcNNn8qF0sqJhqe0M22ZBjimS4jckCBMhKhU+5Vn9G A7+aZdRqJV4u+4crgO7LdaqCl1dJdCNZ0WaTA= From: Bartlomiej Zolnierkiewicz To: Ray Lee Subject: Re: [git pull] IDE fixes Date: Thu, 23 Apr 2009 00:58:59 +0200 User-Agent: KMail/1.11.1 (Linux/2.6.29-next-20090403; KDE/4.2.1; i686; ; ) Cc: Joe Perches , Linus Torvalds , Andrew Morton , Stephen Rothwell , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org References: <200904222048.15556.bzolnier@gmail.com> <200904222341.37846.bzolnier@gmail.com> <2c0942db0904221502x266b66far303102c019e5e0cb@mail.gmail.com> In-Reply-To: <2c0942db0904221502x266b66far303102c019e5e0cb@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200904230059.00680.bzolnier@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1748 Lines: 46 On Thursday 23 April 2009 00:02:38 Ray Lee wrote: > On Wed, Apr 22, 2009 at 2:41 PM, Bartlomiej Zolnierkiewicz > wrote: > > On Wednesday 22 April 2009 21:55:03 Joe Perches wrote: > >> On Wed, 2009-04-22 at 21:43 +0200, Bartlomiej Zolnierkiewicz wrote: > >> > IMO we should just remove extra commas and add some whitespaces. > >> > >> Your choice. > >> Ignore, reject, accept, improve, fine by me. > >> > >> > I have also more general (process oriented) comment: > >> > > >> > All patches have been posted to linux-kernel or linux-ide for review before > >> > and it is _much_ more efficient to raise issues (including CodingStyle ones) > >> > during "review phase" instead of during "push to Linus" phase. > >> > >> Maybe for you, but I'm an intermittent > >> and random reader. > > > > For everybody involved in the process -- this includes you. > > > > I'm not the original author of many patches so I simply cannot be > > correcting every single issue because: > > > > a) it is physically impossible > > > > b) it doesn't really educate people > > His point is that you can queue a follow-up patch to remove the > ugliness. Just because it didn't get caught until the push stage > doesn't mean the code needs to stay set in stone for the rest of > eternity. I get his point and of course patches are welcomed. However my point is that it is still suboptimal way to address the issue in the long-term and from my perspective the long-term is what really matters. Thanks, Bart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/