Message-ID: <49EFC2F7.9050906@kernel.org>
Date: Thu, 23 Apr 2009 10:23:03 +0900
From: Tejun Heo <tj@kernel.org>
User-Agent: Thunderbird 2.0.0.19 (X11/20081227)
MIME-Version: 1.0
To: Jens Axboe <jens.axboe@oracle.com>
CC: Christoph Hellwig <hch@infradead.org>, linux-kernel@vger.kernel.org,
       bzolnier@gmail.com
Subject: Re: [PATCH 07/14] block: reorganize request fetching functions
References: <1240331881-28218-1-git-send-email-tj@kernel.org> <1240331881-28218-8-git-send-email-tj@kernel.org> <20090421170751.GA21156@infradead.org> <20090422100916.GZ4593@kernel.dk>
In-Reply-To: <20090422100916.GZ4593@kernel.dk>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1129
Lines: 30

Jens Axboe wrote:
> On Tue, Apr 21 2009, Christoph Hellwig wrote:
>> On Wed, Apr 22, 2009 at 01:37:54AM +0900, Tejun Heo wrote:
>>> Impact: code reorganization
>>>
>>> elv_next_request() and elv_dequeue_request() are public block layer
>>> interface than actual elevator implementation.  They mostly deal with
>>> how requests interact with block layer and low level drivers at the
>>> beginning of rqeuest processing whereas __elv_next_request() is the
>>> actual eleveator request fetching interface.
>>>
>>> Move the two functions to blk-core.c.  This prepares for further
>>> interface cleanup.
>> As a follow-up patch you might want to rename them to have a more
>> descriptive prefix than elv_ and add some kerneldoc comments for them.
> 
> Hmm dunno, elv_ is fine with me. kerneldoc is always nice, though.
> 

Both changes are scheduled down the pipeline.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/