Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754353AbZDWDTn (ORCPT ); Wed, 22 Apr 2009 23:19:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752655AbZDWDTc (ORCPT ); Wed, 22 Apr 2009 23:19:32 -0400 Received: from rcsinet11.oracle.com ([148.87.113.123]:18958 "EHLO rgminet11.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752289AbZDWDTb (ORCPT ); Wed, 22 Apr 2009 23:19:31 -0400 Message-ID: <49EFDD66.3060407@oracle.com> Date: Wed, 22 Apr 2009 20:15:50 -0700 From: Randy Dunlap Organization: Oracle Linux Engineering User-Agent: Thunderbird 2.0.0.6 (X11/20070801) MIME-Version: 1.0 To: michael@ellerman.id.au CC: Subrata Modak , Paul Mackerras , Linuxppc-dev , Sachin P Sant , linux-kernel , linux-next , Benjamin Herrenschmidt , Stephen Rothwell , Alexander Beregalov , Balbir Singh Subject: Re: [PATCH][BUILD FAILURE 03/12] Re: Next April 21 : PPC64 randconfig [arch/powerpc/kernel/of_platform.o] References: <20090422161648.9231.76057.sendpatchset@subratamodak.linux.ibm.com> <1240447420.6689.13.camel@localhost> In-Reply-To: <1240447420.6689.13.camel@localhost> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Source-IP: acsinet15.oracle.com [141.146.126.227] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A010207.49EFDE07.003A:SCFMA922111,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1634 Lines: 49 Michael Ellerman wrote: > On Wed, 2009-04-22 at 21:46 +0530, Subrata Modak wrote: >> On Wed, 2009-04-22 at 00:20 +0530, Subrata Modak wrote: >>> Reported this earlier on 14th April 2009: >>> http://lkml.org/lkml/2009/4/14/480, >>> >>> Michael, >>> >>> Any fix in sight ? >>> http://lkml.org/lkml/2009/4/14/676, >>> >>> CC arch/powerpc/kernel/of_platform.o >>> arch/powerpc/kernel/of_platform.c: In function 'of_pci_phb_probe': >>> arch/powerpc/kernel/of_platform.c:270: error: implicit declaration of >>> function 'pci_devs_phb_init_dynamic' >>> arch/powerpc/kernel/of_platform.c:279: error: implicit declaration of >>> function 'scan_phb' >>> arch/powerpc/kernel/of_platform.c:295: error: implicit declaration of >>> function 'pci_bus_add_devices' >>> make[1]: *** [arch/powerpc/kernel/of_platform.o] Error 1 >>> make: *** [arch/powerpc/kernel] Error 2 >>> --- > > The problem above is as I said before, that the Cell Kconfig forces on > PPC_OF_PLATFORM_PCI even if PCI is disabled. I think the proper fix is > just to have CELL_NATIVE force on PCI. > > I don't know how you got the other errors, both pci_dn.c and pci_dlpar.c > are only built if CONFIG_PCI is enabled, see the Makefiles. The Kconfig could be more like this: config PPC_CELL_NATIVE bool select PPC_CELL_COMMON - select PPC_OF_PLATFORM_PCI + select PPC_OF_PLATFORM_PCI if PCI if it would help... -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/