Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752473AbZDWFSZ (ORCPT ); Thu, 23 Apr 2009 01:18:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751184AbZDWFSP (ORCPT ); Thu, 23 Apr 2009 01:18:15 -0400 Received: from qw-out-2122.google.com ([74.125.92.27]:25922 "EHLO qw-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751136AbZDWFSP (ORCPT ); Thu, 23 Apr 2009 01:18:15 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; b=L6PeD+NhszwwazjvFgcj9ScZcLXAZLW2RvYof4ZhMipNZqYovREK6on+zWbl+DL/K3 p4+GcChaUqYzlEJf8sFeUsWOAbO08+lUzhRBnB2wTZNgHAL06m1t6v5iWWhqg0RltKOZ g7qS7CYVy0OAUgJuzz7jR89TwFSS4KQvvhQms= Subject: Re: [PATCH 3/3] tracing/filters: disallow newline as delimeter From: Tom Zanussi To: Ingo Molnar Cc: Li Zefan , Steven Rostedt , Frederic Weisbecker , LKML In-Reply-To: <20090422080928.GA8562@elte.hu> References: <49ED8DD2.2070700@cn.fujitsu.com> <49ED8DFD.9070909@cn.fujitsu.com> <20090421095705.GA15448@elte.hu> <49ED9AC2.9000507@cn.fujitsu.com> <20090421100722.GA18486@elte.hu> <49ED9C91.4070201@cn.fujitsu.com> <20090421101619.GA19660@elte.hu> <1240377698.6711.61.camel@tropicana> <20090422080928.GA8562@elte.hu> Content-Type: text/plain Date: Thu, 23 Apr 2009 00:18:12 -0500 Message-Id: <1240463892.9368.44.camel@tropicana> Mime-Version: 1.0 X-Mailer: Evolution 2.24.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3159 Lines: 83 On Wed, 2009-04-22 at 10:09 +0200, Ingo Molnar wrote: > * Tom Zanussi wrote: > > > On Tue, 2009-04-21 at 12:16 +0200, Ingo Molnar wrote: > > > * Li Zefan wrote: > > > > > > > Ingo Molnar wrote: > > > > > * Li Zefan wrote: > > > > > > > > > >> Ingo Molnar wrote: > > > > >>> * Li Zefan wrote: > > > > >>> > > > > >>>> I guess because user input is often ended with '\n' (like "echo > > > > >>>> xxx"), thus '\n' is used as a delimeter besides ' ', but we can > > > > >>>> just strip tailing spaces. > > > > >>> Hm, how about: > > > > >>> > > > > >>> ( echo 'x' > > > > >>> echo '|| y' ) > filter > > > > >>> > > > > >>> type of scripts? Shouldnt the parser be permissive in general? > > > > >>> > > > > >> This patch doesn't forbid this usage: ;) > > > > >> > > > > >> ( echo 'parent_comm == a' > > > > >> echo '|| parent_comm == b' ) > filter > > > > >> > > > > >> This patch does forbid this usage: > > > > >> > > > > >> ( echo 'parent_comm' > > > > >> echo '==' > > > > >> echo 'a' ) > filter > > > > > > > > > > Same argument though, no? > > > > > > > > > > > > > Then I have no strong opinion on this. I'm fine to drop this patch. > > > > > > I've applied the other two - no strong opinion either about this > > > patch. Tom, what do you think? (there's also some new parser in the > > > works i suspect) > > > > I think it works ok as it is, so dropping this patch would be fine > > with me. > > > > I am working on a new parser; I'd hoped to have it finished by > > now, but I seem to be continually distracted lately. :-( At this > > point I have a parser that basically works; the main thing it > > still needs and what I'm working on now is a way to allow it to be > > easily extended to support special-case handling for special types > > e.g. if a predicate field refers to something that's a dev_t, the > > user should be able to specify 'device == /dev/sda' or 'device == > > sda' or 'device == (8,1)' or 'device == 8:1', so it should be > > relatively easy to add that kind of support to the parser when > > there's a need for it. > > > > Once that's done, I'll hook it all up and post it as soon as I > > can, at the end of the week hopefully... > > Nice! :-) > > If your current lineup works you might want to post that straight > away even without the type extensions, if you think there's value in > testing/reviewing those bits independently. It generally works > better to have gradual patches. (we can find bugs sooner, review is > easier, etc.) > Sure, I understand. I wasn't planning on adding any type extensions with the initial parser, just restructuring the code so that adding them wouldn't require a lot of restructuring later. So, yeah, just the basic parser once I get it into a postable state, very soon, and anything else for later... Tom > Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/