Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754098AbZDWHZu (ORCPT ); Thu, 23 Apr 2009 03:25:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752839AbZDWHZh (ORCPT ); Thu, 23 Apr 2009 03:25:37 -0400 Received: from vervifontaine.sonytel.be ([80.88.33.193]:53750 "EHLO pophost.sonytel.be" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752824AbZDWHZg (ORCPT ); Thu, 23 Apr 2009 03:25:36 -0400 Date: Thu, 23 Apr 2009 09:25:30 +0200 (CEST) From: Geert Uytterhoeven To: Michael Ellerman cc: Randy Dunlap , Sachin P Sant , Stephen Rothwell , linux-kernel , Linuxppc-dev , linux-next , Paul Mackerras , Subrata Modak , Alexander Beregalov , Balbir Singh Subject: Re: [PATCH][BUILD FAILURE 03/12] Re: Next April 21 : PPC64 randconfig [arch/powerpc/kernel/of_platform.o] In-Reply-To: <1240460606.6689.32.camel@localhost> Message-ID: References: <20090422161648.9231.76057.sendpatchset@subratamodak.linux.ibm.com> <1240447420.6689.13.camel@localhost> <49EFDD66.3060407@oracle.com> <1240460606.6689.32.camel@localhost> User-Agent: Alpine 2.00 (LRH 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=ISO-8859-15 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2622 Lines: 70 On Thu, 23 Apr 2009, Michael Ellerman wrote: > On Wed, 2009-04-22 at 20:15 -0700, Randy Dunlap wrote: > > Michael Ellerman wrote: > > > On Wed, 2009-04-22 at 21:46 +0530, Subrata Modak wrote: > > >> On Wed, 2009-04-22 at 00:20 +0530, Subrata Modak wrote: > > >>> Reported this earlier on 14th April 2009: > > >>> http://lkml.org/lkml/2009/4/14/480, > > >>> > > >>> Michael, > > >>> > > >>> Any fix in sight ? > > >>> http://lkml.org/lkml/2009/4/14/676, > > >>> > > >>> CC arch/powerpc/kernel/of_platform.o > > >>> arch/powerpc/kernel/of_platform.c: In function 'of_pci_phb_probe': > > >>> arch/powerpc/kernel/of_platform.c:270: error: implicit declaration of > > >>> function 'pci_devs_phb_init_dynamic' > > >>> arch/powerpc/kernel/of_platform.c:279: error: implicit declaration of > > >>> function 'scan_phb' > > >>> arch/powerpc/kernel/of_platform.c:295: error: implicit declaration of > > >>> function 'pci_bus_add_devices' > > >>> make[1]: *** [arch/powerpc/kernel/of_platform.o] Error 1 > > >>> make: *** [arch/powerpc/kernel] Error 2 > > >>> --- > > > > > > The problem above is as I said before, that the Cell Kconfig forces on > > > PPC_OF_PLATFORM_PCI even if PCI is disabled. I think the proper fix is > > > just to have CELL_NATIVE force on PCI. > > > > > > I don't know how you got the other errors, both pci_dn.c and pci_dlpar.c > > > are only built if CONFIG_PCI is enabled, see the Makefiles. > > > > > > The Kconfig could be more like this: > > config PPC_CELL_NATIVE > > bool > > select PPC_CELL_COMMON > > - select PPC_OF_PLATFORM_PCI > > + select PPC_OF_PLATFORM_PCI if PCI > > That might be better. Although I think in truth the Cell code won't > build without PCI, but we could fix that. As I said in my patch I think > we do want PCI on Cell native, so we should just select it too. > > http://patchwork.ozlabs.org/patch/26338/ Last time this came up, it was mentioned that QPACE doesn't have PCI. With kind regards, Geert Uytterhoeven Software Architect Techsoft Centre Technology and Software Centre Europe The Corporate Village ? Da Vincilaan 7-D1 ? B-1935 Zaventem ? Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven@sonycom.com Internet: http://www.sony-europe.com/ A division of Sony Europe (Belgium) N.V. VAT BE 0413.825.160 ? RPR Brussels Fortis ? BIC GEBABEBB ? IBAN BE41293037680010 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/