Return-Path: <linux-kernel-owner+w=401wt.eu-S1757471AbZDWLCy@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757471AbZDWLCy (ORCPT <rfc822;w@1wt.eu>);
	Thu, 23 Apr 2009 07:02:54 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753022AbZDWLCo
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 23 Apr 2009 07:02:44 -0400
Received: from cam-admin0.cambridge.arm.com ([193.131.176.58]:34881 "EHLO
	cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751445AbZDWLCn (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 23 Apr 2009 07:02:43 -0400
Subject: Re: linux-next: Tree for April 22: kmemleak: unreferenced object
From: Catalin Marinas <catalin.marinas@arm.com>
To: Matthias Kaehlcke <matthias@kaehlcke.net>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>, linux-next@vger.kernel.org,
       LKML <linux-kernel@vger.kernel.org>
In-Reply-To: <20090422124932.GA26289@traven>
References: <20090422154247.dbffd285.sfr@canb.auug.org.au>
	 <20090422124932.GA26289@traven>
Content-Type: text/plain
Organization: ARM Ltd
Date: Thu, 23 Apr 2009 12:01:29 +0100
Message-Id: <1240484489.20564.32.camel@pc1117.cambridge.arm.com>
Mime-Version: 1.0
X-Mailer: Evolution 2.22.3.1 
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 23 Apr 2009 11:02:13.0475 (UTC) FILETIME=[F4EA6330:01C9C402]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1475
Lines: 39

On Wed, 2009-04-22 at 14:49 +0200, Matthias Kaehlcke wrote:
> shortly after booting next-20090422 on an ep9301, kmemleak complains
> about an unreferenced object:
> 
> kmemleak: unreferenced object 0xc5408610 (size 5):
>   comm "swapper", pid 0, jiffies 4294937323
>   backtrace:
>     [<c00267e0>] save_stack_trace+0x24/0x28
>     [<c00a3db4>] kmemleak_alloc+0x144/0x2cc
>     [<c00a211c>] __kmalloc_node+0x1bc/0x1d4
>     [<c008d730>] kstrdup+0x3c/0x54
>     [<c00bedec>] alloc_vfsmnt+0x9c/0x148
>     [<c00a7c10>] vfs_kern_mount+0x34/0xa8
>     [<c00a7ca4>] kern_mount_data+0x20/0x24
>     [<c0013428>] bdev_cache_init+0x54/0xa0
>     [<c0012c74>] vfs_caches_init+0x104/0x140
>     [<c0008980>] start_kernel+0x244/0x2b8
>     [<00008034>] 0x8034
>     [<ffffffff>] 0xffffffff

That's a known leak happening in bdev_cache_init() - the bd_mnt pointer
is never freed (and people argued that we shouldn't be bothered with
freeing it). I marked it with kmemleak_ignore() but forgot about the
block allocated by kstrdup() in alloc_vfsmnt() and referenced from the
vfsmount structure.

I'll change kmemleak_ignore() to kmemleak_not_leak() so that the
vfsmount structure is scanned for other referenced objects.

Thanks.

-- 
Catalin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/