Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757275AbZDWNQo (ORCPT ); Thu, 23 Apr 2009 09:16:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753766AbZDWNQf (ORCPT ); Thu, 23 Apr 2009 09:16:35 -0400 Received: from mail-fx0-f158.google.com ([209.85.220.158]:35796 "EHLO mail-fx0-f158.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753762AbZDWNQe (ORCPT ); Thu, 23 Apr 2009 09:16:34 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:cc:subject:date:message-id:x-mailer; b=aZKIuVMNM0IJMg0Z20SQT+R2mX0bb0hlx1Fqo2pJ5NAVc33MYLqn3VJ0lmcmZeoSH1 pNh7kVefR11LOYk6OBf/DoIKpdoadwA/Or34ednRsTUlQrWtmH5sK+7pUguu0TkRKIZQ Um/RsxzxExk5yl9p+vsaVKxSpc+FrFGkKMwfk= From: Alessio Igor Bogani To: Ingo Molnar Cc: Jonathan Corbet , =?utf-8?q?Fr=C3=A9d=C3=A9ric=20Weisbecker?= , Peter Zijlstra , LKML , Alessio Igor Bogani Subject: [PATCH -tip] remove the BKL: remove "BKL auto-drop" assumption from ext3_remount() Date: Thu, 23 Apr 2009 15:16:26 +0200 Message-Id: <1240492586-6654-1-git-send-email-abogani@texware.it> X-Mailer: git-send-email 1.6.0.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1058 Lines: 33 Fix ext3_remount()'s "schedule() drops the BKL automatically" assumption, when ext3_mark_recovery_complete(), which can sleep, does not do that it can lock up. Signed-off-by: Alessio Igor Bogani --- fs/ext3/super.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/ext3/super.c b/fs/ext3/super.c index dc905f9..3fa457a 100644 --- a/fs/ext3/super.c +++ b/fs/ext3/super.c @@ -2561,9 +2561,11 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data) * We have to unlock super so that we can wait for * transactions. */ + unlock_kernel(); unlock_super(sb); ext3_mark_recovery_complete(sb, es); lock_super(sb); + lock_kernel(); } else { __le32 ret; if ((ret = EXT3_HAS_RO_COMPAT_FEATURE(sb, -- 1.6.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/