Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754008AbZDWR1w (ORCPT ); Thu, 23 Apr 2009 13:27:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751829AbZDWR1m (ORCPT ); Thu, 23 Apr 2009 13:27:42 -0400 Received: from sous-sol.org ([216.99.217.87]:49639 "EHLO sequoia.sous-sol.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751511AbZDWR1m (ORCPT ); Thu, 23 Apr 2009 13:27:42 -0400 Date: Thu, 23 Apr 2009 10:21:38 -0700 From: Chris Wright To: Jeremy Fitzhardinge Cc: Steven Rostedt , Ingo Molnar , =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , LKML , Andrew Morton , Glauber de Oliveira Costa , Chris Wright , Rusty Russell , Pekka Enberg Subject: Re: [PATCH 0/2] [GIT PULL] tracing: various bug fixes Message-ID: <20090423172138.GR3036@sequoia.sous-sol.org> References: <20090420222257.267399830@goodmis.org> <20090421082354.GC12512@elte.hu> <20090421094616.GA14561@elte.hu> <20090423082031.GA599@elte.hu> <49F09C35.1080006@goop.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49F09C35.1080006@goop.org> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1823 Lines: 59 * Jeremy Fitzhardinge (jeremy@goop.org) wrote: > OK, the good news is that its not a callee-save calling convention > problem, which is what I feared. But it does sound pretty awkward to > fix. Does __native_flush_tlb_global() have to use > raw_local_irq_save/restore? Vaguely related...makes sense to do native_(read/write)_cr4 since it's the native tlb flushing implementation, no? looks ok from inspection, not tested yet... thanks, -chris -- Subject: [PATCH] x86: use native register access for native tlb flushing currently these are paravirtulaized, doesn't appear any callers rely on this (no pv_ops backends are using native_tlb and overriding cr3/4 access). Signed-off-by: Chris Wright --- arch/x86/include/asm/tlbflush.h | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h index 16a5c84..a5ecc9c 100644 --- a/arch/x86/include/asm/tlbflush.h +++ b/arch/x86/include/asm/tlbflush.h @@ -17,7 +17,7 @@ static inline void __native_flush_tlb(void) { - write_cr3(read_cr3()); + native_write_cr3(native_read_cr3()); } static inline void __native_flush_tlb_global(void) @@ -32,11 +32,11 @@ static inline void __native_flush_tlb_global(void) */ raw_local_irq_save(flags); - cr4 = read_cr4(); + cr4 = native_read_cr4(); /* clear PGE */ - write_cr4(cr4 & ~X86_CR4_PGE); + native_write_cr4(cr4 & ~X86_CR4_PGE); /* write old PGE again and flush TLBs */ - write_cr4(cr4); + native_write_cr4(cr4); raw_local_irq_restore(flags); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/