DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=0jQInAVbjh/v3yZo8mZwsCiFYbY02yJ9j78O0ToNj4DrL+EKywUPBJzdYlidNJ61z/N7Y1YU1/jVI5HMYtdhBLN+WBUbhAU1rgvkd+r5NqlDz/kFPZn3HtedKZAjLO7O0xyREkhoVydTu9q5BVrUqW66ycbOxQuIK2JdOEDKcl0=  ;
From: David Brownell <david-b@pacbell.net>
To: Alessandro Zummo <alessandro.zummo@towertech.it>
Subject: Re: [PATCH] rtc: Make rtc_update_irq callable with irqs enabled
Date: Thu, 23 Apr 2009 11:15:56 -0700
User-Agent: KMail/1.9.10
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>, akpm@linux-foundation.org,
       rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
       hcegtvedt@atmel.com, vapier@gentoo.org, rongkai.zhan@windriver.com,
       balajirrao@openmoko.org, broonie@opensource.wolfsonmicro.com
References: <20090410005820.4fcfcc1f@i1501.lan.towertech.it> <20090424.002900.11623503.anemo@mba.ocn.ne.jp> <20090423174641.2b03e7a7@i1501.lan.towertech.it>
In-Reply-To: <20090423174641.2b03e7a7@i1501.lan.towertech.it>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Message-Id: <200904231115.57525.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 829
Lines: 23

On Thursday 23 April 2009, Alessandro Zummo wrote:
> ?Is not an API change, we are gradually relaxing it if it
> ?proves workable :)

Erm, it *is* an API change at least to the extent that
the last version of the patch made the interface spec
become incorrect.

Current interface spec *requires* that function to be
called with IRQs disabled.

The downside of that spec is that there's no way to test
it, since CONFIG_LOCKDEP doesn't understand that almost
all IRQ handlers don't disable IRQs.  So there are some
bugs in RTC drivers that can only be uncovered by code
review.

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/