Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753658AbZDXHc1 (ORCPT ); Fri, 24 Apr 2009 03:32:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752510AbZDXHcS (ORCPT ); Fri, 24 Apr 2009 03:32:18 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:52080 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752180AbZDXHcR (ORCPT ); Fri, 24 Apr 2009 03:32:17 -0400 Date: Fri, 24 Apr 2009 09:31:15 +0200 From: Ingo Molnar To: Greg KH , Andreas Herrmann , Dmitry Adamushko , Hugh Dickins Cc: Andrew Morton , Zdenek Kabelac , linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Rusty Russell , Kay Sievers Subject: Re: WARNING: at fs/sysfs/group.c:138 sysfs_remove_group Message-ID: <20090424073115.GF24912@elte.hu> References: <20090423130930.50a6c9db.akpm@linux-foundation.org> <20090423203945.GA3890@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090423203945.GA3890@kroah.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5033 Lines: 129 (more people Cc:-ed - some microcode driver sysdev badness) * Greg KH wrote: > On Thu, Apr 23, 2009 at 01:09:30PM -0700, Andrew Morton wrote: > > On Fri, 17 Apr 2009 11:13:08 +0200 > > Zdenek Kabelac wrote: > > > > > Hi > > > > > > > > > When I've checked 2.6.30-rc2 kernel and I've got among other errors > > > with Wifi message below. > > > As I've noticed - some people were reporting this problem already earlier: > > > > > > http://www.gossamer-threads.com/lists/linux/kernel/1058276?page=last > > > > > > But for me - it started with 2.6.30-rc kernels. > > > I've T61, 4GB, C2D, X86_64. > > > > > > > > > > > > Zdenek > > > > > > > > > platform microcode: firmware: requesting intel-ucode/06-0f-0a > > > platform microcode: firmware: requesting intel-ucode/06-0f-0a > > > > Lots of people are reporting this. One person reported that each > > attempt takes 60 seconds, thus delaying boot be several minutes. > > > > > Microcode Update Driver: v2.00 , Peter Oruba > > > ------------[ cut here ]------------ > > > WARNING: at fs/sysfs/group.c:138 sysfs_remove_group+0x10b/0x110() > > > Hardware name: 6464CTO > > > sysfs group ffffffffa038d900 not found for kobject 'cpu0' > > > Modules linked in: microcode(-) binfmt_misc dm_mirror dm_region_hash > > > dm_log dm_mod kvm_intel kvm i915 dr > > > m i2c_algo_bit uinput btusb bluetooth arc4 ecb cryptomgr aead > > > pcompress thinkpad_acpi snd_hda_codec_analog crypto_blkcipher > > > crypto_hash snd_hda_intel cry > > > pto_algapi snd_hda_codec iwl3945 snd_seq_oss iwlcore > > > snd_seq_midi_event mac80211 snd_seq rfkill backlight i2c_i801 psmouse > > > intel_agp snd_seq_device snd_p > > > cm_oss rtc_cmos rtc_core sr_mod cdrom i2c_core sdhci_pci sdhci > > > mmc_core serio_raw led_class iTCO_wdt iTCO_vendor_support nvram > > > cfg80211 snd_mixer_oss e10 > > > 00e rtc_lib snd_pcm snd_timer snd evdev soundcore button ac battery > > > snd_page_alloc uhci_hcd ohci_hcd ehci_hcd usbcore [last unloaded: > > > scsi_wait_scan] > > > Pid: 1983, comm: rmmod Not tainted 2.6.30-rc2-00076-g3ee8da8 #51 > > > Call Trace: > > > [] warn_slowpath+0xaf/0xf0 > > > [] ? kobject_release+0x5d/0xa0 > > > [] sysfs_remove_group+0x10b/0x110 > > > [] mc_sysdev_remove+0x38/0x50 [microcode] > > > [] sysdev_driver_unregister+0x5f/0xa0 > > > [] microcode_exit+0x39/0x65 [microcode] > > > [] sys_delete_module+0x1b4/0x280 > > > [] ? __up_write+0xd8/0x150 > > > [] ? trace_hardirqs_on_thunk+0x3a/0x3c > > > [] system_call_fastpath+0x16/0x1b > > > > ugh, where to start? > > > > sysdev_driver_register() calls all the ->add methods and cheerily drops > > their return codes on the floor. Consequently > > sysdev_driver_unregister() will call the ->remove method on objects > > which were not successfully add()ed. > > Ugh, the sysdev code sucks so badly it's not funny. It's next on my > chopping block for cleanups, need to still do some driver core rework > first though :( > > > mc_sysdev_add() will return an error if microcode_init_cpu() failed but > > fails to remove its attr_group in that case. So if > > sysdev_driver_register()/sysdev_driver_unregister() get fixed, > > microcode will misbehave. > > > > This patch: > > > > : commit af5c820a3169e81af869c113e18ec7588836cd50 > > : Author: Rusty Russell > > : AuthorDate: Wed Mar 11 16:32:36 2009 +1030 > > : Commit: Ingo Molnar > > : CommitDate: Wed Mar 18 13:50:47 2009 +0100 > > : > > : x86: cpumask: use work_on_cpu in arch/x86/kernel/microcode_core.c > > : > > > > attempted to fix things up a bit: > > > > : @@ -379,8 +390,11 @@ static int mc_sysdev_add(struct sys_device *sys_dev) > > : if (err) > > : return err; > > : > > : - microcode_init_cpu(cpu); > > : - return 0; > > : + err = microcode_init_cpu(cpu); > > : + if (err) > > : + sysfs_remove_group(&sys_dev->kobj, &mc_attr_group); > > : + > > : + return err; > > : } > > : > > : static int mc_sysdev_remove(struct sys_device *sys_dev) > > > > But it seems that the sysfs_remove_group() later got removed again. > > So, this is a microcode specific issue? Hm, it really doesnt do anything fancy. I've Cc:-ed a few more folks. There's a patch to try in this thread on lkml: [PATCH] x86 microcode: work_on_cpu and cleanup of the synchronization logic (note, try the v2 patch in that discussion. There will be a v3 patch too there.) But that patch does not specifically address any sysdev related buglet. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/