Date: Fri, 24 Apr 2009 12:09:43 +0200
From: Robert Richter <robert.richter@amd.com>
To: Huang Ying <ying.huang@intel.com>
CC: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
       Thomas Gleixner <tglx@linutronix.de>, Andi Kleen <ak@linux.intel.com>,
       "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
       Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
       Steven Rostedt <rostedt@goodmis.org>
Subject: Re: Re-implement MCE log ring buffer as per-CPU ring buffer
Message-ID: <20090424100943.GJ27264@erda.amd.com>
References: <1240391484.6842.474.camel@yhuang-dev.sh.intel.com> <20090422092259.GC18226@elte.hu> <20090422101600.GL3226@erda.amd.com> <1240553210.6842.871.camel@yhuang-dev.sh.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1240553210.6842.871.camel@yhuang-dev.sh.intel.com>
User-Agent: Mutt/1.5.16 (2007-06-09)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1407
Lines: 39

On 24.04.09 14:06:50, Huang Ying wrote:
> On Wed, 2009-04-22 at 18:16 +0800, Robert Richter wrote:
> > On 22.04.09 11:22:59, Ingo Molnar wrote:
> > > 
> > > * Huang Ying <ying.huang@intel.com> wrote:
> > > 
> > > > Re-implement MCE log ring buffer as per-CPU ring buffer for better 
> > > > scalability. Basic design is as follow:
> > > 
> > > Before changing anything substantial in the MCE code it would be 
> > > necessary to clean up and then unify the 32-bit and 64-bit side of 
> > > the MCE code first. (Which essentially means extending the 
> > > 64-bit-only code to 32-bit)
> > 
> > You may also want to consider to use the in-kernel ring_buffer api
> > (include/linux/ring_buffer.h).
> 
> It seems that ring_buffer is not NMI-safe, while mcelog buffer will be
> used in NMI context and interrupt context. When will ring_buffer to be
> NMI-safe?

You can use it in nmi context with separate read and write
buffers. See this patch description:
6dad828b76c7224a22ddc9ce7aa495d994f03b31

Not sure if somebody will make the ring_buffer non-locking.

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/