Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759554AbZDXPdv (ORCPT ); Fri, 24 Apr 2009 11:33:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755256AbZDXPdm (ORCPT ); Fri, 24 Apr 2009 11:33:42 -0400 Received: from BISCAYNE-ONE-STATION.MIT.EDU ([18.7.7.80]:50900 "EHLO biscayne-one-station.mit.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752812AbZDXPdl (ORCPT ); Fri, 24 Apr 2009 11:33:41 -0400 Date: Fri, 24 Apr 2009 11:32:55 -0400 (EDT) From: Tim Abbott To: Masami Hiramatsu cc: Linus Torvalds , Linux kernel mailing list , Anders Kaseorg , Waseem Daher , Denys Vlasenko , Rusty Russell , Andi Kleen , "H. Peter Anvin" , Stephen Rothwell , Jeff Arnold , Andrew Morton , Jon Masters , "Theodore Ts'o" , Nikanth Karthikesan , Arjan van de Ven , Paul Mundt , =?ISO-8859-15?Q?Am=E9rico_Wang?= , Ralf Baechle , Kyle McMaartin , David Howells Subject: Re: [PATCH v3 0/3] Add support for compiling with -ffunction-sections -fdata-sections In-Reply-To: <49F1CA6E.5080407@redhat.com> Message-ID: References: <1238973278-31735-1-git-send-email-tabbott@mit.edu> <49F1CA6E.5080407@redhat.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Flag: NO X-Spam-Score: 0.00 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1765 Lines: 41 On Fri, 24 Apr 2009, Masami Hiramatsu wrote: > What would you think about posting these patches plus -ffunction-sections/ > -fdata-sections patch to -mm tree, -tip tree, or -next tree as > "playable" Ksplice patchset? The section rename patch often merge conflicts with other changes. I think that having it sit out in one of those trees for another release would result in a lot of unnecessary work rebasing patches between that tree and Linus' tree. Once these -ffunction-sections support patches are merged, I intend to post the rest of the Ksplice patchset for one of those trees. > If there are actual problems on those arch, I think you'd better post > these patches as bugfixes with bug reports. These problems are all discussed in the commit messages of the relevant patches. One patch fixes modposting a kernel with more than 65536 ELF sections. It is certainly possible to get this many with allyesconfig and -ffunction-sections -fdata-sections. Another fixes the issue that when you build with -ffunction-sections, modpost will print a large number of spurious warnings when it sees sections like .rodata.__func__.12345 which are generated by the __FUNC__ macro. The patch with many scattered changes fixes the problem that with -ffunction-sections -fdata-sections, a function named head gets put in the ".text.head" section, and your "static int percpu" ends up in the ".data.percpu" section and probably ends up being made percpu. This is a potentially nasty problem. -Tim Abbott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/