Date: Fri, 24 Apr 2009 10:46:51 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: David Daney <ddaney@caviumnetworks.com>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Introduce a boolean "single_bit_set" function.
Message-Id: <20090424104651.7c751735.akpm@linux-foundation.org>
In-Reply-To: <alpine.LFD.2.00.0904240632240.16107@localhost.localdomain>
References: <alpine.LFD.2.00.0904231339080.13089@localhost.localdomain>
	<49F0C817.8050407@caviumnetworks.com>
	<20090423165723.16c9f566.akpm@linux-foundation.org>
	<alpine.LFD.2.00.0904240632240.16107@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1212
Lines: 41

On Fri, 24 Apr 2009 06:40:39 -0400 (EDT) "Robert P. J. Day" <rpjday@crashcourse.ca> wrote:

>   so it would be a simple matter to define the bit set boolean in
> terms of hweight_long(), yes?  so what about, in bitops.h:
> 
>   static inline bool
>   exactly_one_bit_set(unsigned long w)
>   {
> 	return hweight_long(w) == 1;
>   }
> 
>   static inline bool
>   more_than_one_bit_set(unsigned long w)
>   {
> 	return hweight_long(w) > 1;
>   }
> 
> or something to that effect, *if* people think it's worth it.
> obviously, none of the above is strictly necessary, but it would make
> a lot of code semantically cleaner.
> 

Doing plain old

	if (hweight32(foo) == 1)

(say) at the call sites quite clearly expresses what the code is trying
to do.

> rday
> 
> p.s.  i notice that, even in a single header file like bitops.h, there
> is a mixture of both "inline" and "__inline__".  what's the
> recommended choice these days?

`inline'.  Or uninline the function ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/