Date: Fri, 24 Apr 2009 18:28:21 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: zhaolei@cn.fujitsu.com, mingo@elte.hu, kosaki.motohiro@jp.fujitsu.com,
       rostedt@goodmis.org, tzanussi@gmail.com, linux-kernel@vger.kernel.org,
       oleg@redhat.com
Subject: Re: [PATCH 0/4] workqueue_tracepoint: Add worklet tracepoints for
 worklet lifecycle tracing
Message-Id: <20090424182821.8263f445.akpm@linux-foundation.org>
In-Reply-To: <20090425003702.GC6658@nowhere>
References: <20090415085310.AC0D.A69D9226@jp.fujitsu.com>
	<20090415011533.GI5968@nowhere>
	<20090415141250.AC46.A69D9226@jp.fujitsu.com>
	<49E8282A.6010004@cn.fujitsu.com>
	<49E82CA7.2040606@cn.fujitsu.com>
	<20090417134557.GA23493@elte.hu>
	<49F1A59B.3080206@cn.fujitsu.com>
	<20090424130616.a3c217cb.akpm@linux-foundation.org>
	<20090424225909.GA6658@nowhere>
	<20090424162056.45907fef.akpm@linux-foundation.org>
	<20090425003702.GC6658@nowhere>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1655
Lines: 45

On Sat, 25 Apr 2009 02:37:03 +0200
Frederic Weisbecker <fweisbec@gmail.com> wrote:

> I discovered it with this tracer. Then it brought me to
> write this patch:
> 
> http://lkml.org/lkml/2009/1/31/184
> 
> ...
> 
> Still with these same observations, I wrote this another one:
> 
> http://lkml.org/lkml/2009/1/26/363

OK, it's great that you're working to improve the workqueue code.  But
does this justify permanently adding debug code to the core workqueue
code?  In fact, because you've discovered these problem, the reasons
for adding the debug code have lessened!

What we need are curious developers looking into how well subsystems
are performing and how well callers are using them.  Adding fairly
large amounts of permanent debug code into the core subsystems is a
peculiar way of encouraging such activity.

If a developer is motivated to improve (say) workqueues then they will
write a bit of ad-hoc code, or poke at it with systemtap or will
maintain a private ftrace patch - that's all pretty simple stuff for
such people.

So what is the remaining case for adding these patches?  What I see is

a) that their presence will entice people to run them and maybe find
   some problems and

b) the workqueue-maintainer's task is lessened a bit by not having
   to forward-port his debugging patch.

I dunno, it all seems a bit thin to me.  Especially when you multiply
it all by nr_core_subsystems?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/