Date: Sat, 25 Apr 2009 19:25:24 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: David Howells <dhowells@redhat.com>
Cc: Roland McGrath <roland@redhat.com>,
       Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org,
       James Morris <jmorris@namei.org>, Hugh Dickins <hugh@veritas.com>
Subject: Re: ptrace && cred_exec_mutex (Was: [PATCH] ptrace:
	tracehook_unsafe_exec: remove the stale comment)
Message-ID: <20090425172524.GA3432@redhat.com>
References: <20090424163949.GA12035@redhat.com> <20090423212250.GA22537@redhat.com> <20090423232717.975ABFC3C7@magilla.sf.frob.com> <31842.1240656853@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <31842.1240656853@redhat.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1243
Lines: 45

On 04/25, David Howells wrote:
>
> Oleg Nesterov <oleg@redhat.com> wrote:
>
> > Yes. Except it looks like ->cred_exec_mutex is never used in fact.
>
> I must to be missing something...  I see that:
>
> 	int ptrace_attach(struct task_struct *task)
> 	{
> 	...
> 		/* Protect exec's credential calculations against our interference;
> 		 * SUID, SGID and LSM creds get determined differently under ptrace.
> 		 */
> 		retval = mutex_lock_interruptible(&current->cred_exec_mutex);
> 	...
> 	}
>
> And:
>
> 	int do_execve(...)
> 	{
> 	...
> 		retval = mutex_lock_interruptible(&current->cred_exec_mutex);
> 		if (retval < 0)
> 			goto out_free;
> 	...
> 	}

Sorry David, I was very unclear.

These 2 current's are different tasks, and hence we take to unrelated locks.

We can never block taking current->cred_exec_mutex because nobody else
touches this mutex, we always use current. This means this lock is "nop".

Unless I missed something, ptrace_attach() should take task->cred_exec_mutex.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/