Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755342AbZDZL0k (ORCPT ); Sun, 26 Apr 2009 07:26:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752706AbZDZL0a (ORCPT ); Sun, 26 Apr 2009 07:26:30 -0400 Received: from pfepb.post.tele.dk ([195.41.46.236]:58794 "EHLO pfepb.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752305AbZDZL03 (ORCPT ); Sun, 26 Apr 2009 07:26:29 -0400 Date: Sun, 26 Apr 2009 13:28:38 +0200 From: Sam Ravnborg To: Tim Abbott Cc: Linus Torvalds , Linux kernel mailing list , Anders Kaseorg , Waseem Daher , Denys Vlasenko , Rusty Russell , Andi Kleen , "H. Peter Anvin" , Stephen Rothwell , Jeff Arnold , Andrew Morton , Jon Masters , Masami Hiramatsu , "Theodore Ts'o" , Nikanth Karthikesan , Arjan van de Ven , Paul Mundt , =?iso-8859-1?Q?Am=E9rico?= Wang , Ralf Baechle , Kyle McMartin , David Howells , Thomas Gleixner , Ingo Molnar Subject: Re: [PATCH 14/15] x86: convert to use __HEAD and HEAD_TEXT macros. Message-ID: <20090426112838.GM28642@uranus.ravnborg.org> References: <1240711870-30505-5-git-send-email-tabbott@mit.edu> <1240711870-30505-6-git-send-email-tabbott@mit.edu> <1240711870-30505-7-git-send-email-tabbott@mit.edu> <1240711870-30505-8-git-send-email-tabbott@mit.edu> <1240711870-30505-9-git-send-email-tabbott@mit.edu> <1240711870-30505-10-git-send-email-tabbott@mit.edu> <1240711870-30505-11-git-send-email-tabbott@mit.edu> <1240711870-30505-12-git-send-email-tabbott@mit.edu> <1240711870-30505-13-git-send-email-tabbott@mit.edu> <1240711870-30505-14-git-send-email-tabbott@mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1240711870-30505-14-git-send-email-tabbott@mit.edu> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1962 Lines: 42 On Sat, Apr 25, 2009 at 10:11:09PM -0400, Tim Abbott wrote: > This has the consequence of changing the section name use for head > code from ".text.head" to ".head.text". Since this commit changes all > users in the architecture, this change should be harmless. > > Signed-off-by: Tim Abbott > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: H. Peter Anvin > --- > arch/x86/boot/compressed/Makefile | 2 + > arch/x86/boot/compressed/head_32.S | 3 +- > arch/x86/boot/compressed/head_64.S | 3 +- > arch/x86/boot/compressed/vmlinux_32.lds | 43 ------------------------- > arch/x86/boot/compressed/vmlinux_32.lds.S | 45 ++++++++++++++++++++++++++ > arch/x86/boot/compressed/vmlinux_64.lds | 48 --------------------------- > arch/x86/boot/compressed/vmlinux_64.lds.S | 50 +++++++++++++++++++++++++++++ > arch/x86/kernel/head_32.S | 2 +- > arch/x86/kernel/head_64.S | 2 +- > arch/x86/kernel/vmlinux_32.lds.S | 4 +- > arch/x86/kernel/vmlinux_64.lds.S | 2 +- > 11 files changed, 106 insertions(+), 98 deletions(-) > delete mode 100644 arch/x86/boot/compressed/vmlinux_32.lds > create mode 100644 arch/x86/boot/compressed/vmlinux_32.lds.S > delete mode 100644 arch/x86/boot/compressed/vmlinux_64.lds > create mode 100644 arch/x86/boot/compressed/vmlinux_64.lds.S You should split this patch up in smaller pieces. 1) Rename from *lds to *.lds.S (and no other changes) 2) Introduce __HEAD & friends And as before do not use HEAD_TEXT_SECTION But otherwise it looks good. I will take a second look when new patches are sent. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/