Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753940AbZDZMAv (ORCPT ); Sun, 26 Apr 2009 08:00:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752577AbZDZMAk (ORCPT ); Sun, 26 Apr 2009 08:00:40 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:59855 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752305AbZDZMAk (ORCPT ); Sun, 26 Apr 2009 08:00:40 -0400 Date: Sun, 26 Apr 2009 13:00:37 +0100 From: Mark Brown To: Mike Rapoport Cc: lrg@slimlogic.co.uk, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] regulator: add userspace-consumer driver Message-ID: <20090426120036.GA10900@opensource.wolfsonmicro.com> References: <20090426100211.GC9009@opensource.wolfsonmicro.com> <49F449B8.2010707@compulab.co.il> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49F449B8.2010707@compulab.co.il> X-Cookie: You will wish you hadn't. User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1035 Lines: 21 On Sun, Apr 26, 2009 at 02:47:04PM +0300, Mike Rapoport wrote: > Mark Brown wrote: > > Why are you using a regulator_consumer_supply here? All that's being > > used here is the name and I can't see why you'd want the device. > For upwards compatibility :) > Well, seriously, I think using 'struct regulator_consumer_supply *supplies' > rather than 'char *supplies' makes the platform code that registers the > userspace-consumer device clearer. On the other hand it merges the consumer and machine APIs, which we really want to keep separate, and I can't see having the struct device in there doing anything except confuse people. If you're going to pick an existing structure to use I'd be more inclined to use the bulk consumer structure (which the driver needs to allocate anyway). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/