Message-ID: <49F48A0E.30301@phoenixsoftware.de>
Date: Sun, 26 Apr 2009 18:21:34 +0200
From: Tilman Schmidt <t.schmidt@phoenixsoftware.de>
User-Agent: Thunderbird 2.0.0.19 (X11/20081227)
MIME-Version: 1.0
To: =?UTF-8?B?T3phbiDDh2HEn2xheWFu?= <ozan@pardus.org.tr>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: The current status of info, err and warn macros in kernel
References: <49F39786.6020303@pardus.org.tr>
In-Reply-To: <49F39786.6020303@pardus.org.tr>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1476
Lines: 35

Ozan Çağlayan schrieb:
> I noticed that I can't compile some out-of-tree modules like lirc,
> lmpcm_usb on my 2.6.30_rc* source tree.
> The compiler aborts saying "implicit declaration of function 'info'". [...] 
> I don't think that those macros are completely removed because it seems
> that they're still heavily in use
> after grepping on current linus-2.6 tree.

Your grepping must have been inexact. info() and warn() have been removed
completely in 2.6.29 already, and are indeed used nowhere in the current
tree. (err() is still there, though probably not for long.)

Suitable replacements are either the dev_* macros from device.h (only
usable if there is a reliably valid device pointer available - be
careful when using them in error handling!) or the pr_* macros from
kernel.h with an appropriate definition of pr_fmt(f).

> So, is it possible that there's a Kconfig option which makes the
> compilation fail on those macros?

Definitely not. They are gone, period.

> Why am I not able to compile those modules? Am I missing something?

The out-of-tree modules have to be adapted for kernel release 2.6.29.
That's the fate of out-of-tree modules - they tend to break with every
other new kernel release.

HTH
Tilman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/