Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754186AbZD0ALt (ORCPT ); Sun, 26 Apr 2009 20:11:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752029AbZD0ALo (ORCPT ); Sun, 26 Apr 2009 20:11:44 -0400 Received: from gate.crashing.org ([63.228.1.57]:37601 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751643AbZD0ALn (ORCPT ); Sun, 26 Apr 2009 20:11:43 -0400 Subject: Re: Porting the ibm_newemac driver to use phylib (and other PHY/MAC questions) From: Benjamin Herrenschmidt To: Kyle Moffett Cc: Josh Boyer , netdev , "Linux-Kernel@Vger. Kernel. Org" , linuxppc-dev@ozlabs.org In-Reply-To: References: <625fc13d0904200529l152b8d75g33c3f940de1b2920@mail.gmail.com> Content-Type: text/plain Date: Wed, 22 Apr 2009 10:21:16 +0200 Message-Id: <1240388476.17445.10.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1098 Lines: 26 On Mon, 2009-04-20 at 20:10 -0400, Kyle Moffett wrote: > > IIRC, Ben had some issues with how phylib and the EMAC would need to > > interact. Not sure if he has those written down somewhere or not. > > (CC'd). > > Hmm, yeah, I'd be interested to see those. There's enough similar > between phylib and the EMAC and sungem drivers that I'm considering a > series of somewhat-mechanical patches to make EMAC and sungem use the > "struct phy_device" and "struct mii_bus" from phylib, possibly > abstracting out some helper functions along the way. Yup, emac and sungem predate phylib. I had a quick look at what it would take to port at least emac over, the main issue was that I want to be able to sleep (ie, take a mutex) in my mdio read/write functions, and back then, phylib wouldn't let me do that due to spinlock and timer/softirq usage. Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/