Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754988AbZD0HlX (ORCPT ); Mon, 27 Apr 2009 03:41:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752522AbZD0HlJ (ORCPT ); Mon, 27 Apr 2009 03:41:09 -0400 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:33243 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751962AbZD0HlG (ORCPT ); Mon, 27 Apr 2009 03:41:06 -0400 Date: Mon, 27 Apr 2009 16:39:30 +0900 From: KAMEZAWA Hiroyuki To: nishimura@mxp.nes.nec.co.jp Cc: Daisuke Nishimura , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "balbir@linux.vnet.ibm.com" , "hugh@veritas.com" Subject: Re: [RFC][PATCH] fix swap entries is not reclaimed in proper way for memg v3. Message-Id: <20090427163930.50604bf9.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20090426010658.c0fa3258.d-nishimura@mtf.biglobe.ne.jp> References: <20090421162121.1a1d15fe.kamezawa.hiroyu@jp.fujitsu.com> <20090422143833.2e11e10b.nishimura@mxp.nes.nec.co.jp> <20090424133306.0d9fb2ce.kamezawa.hiroyu@jp.fujitsu.com> <20090424152103.a5ee8d13.nishimura@mxp.nes.nec.co.jp> <20090424162840.2ad06d8a.kamezawa.hiroyu@jp.fujitsu.com> <20090425215459.5cab7285.d-nishimura@mtf.biglobe.ne.jp> <20090426010658.c0fa3258.d-nishimura@mtf.biglobe.ne.jp> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 2.5.0 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1996 Lines: 78 On Sun, 26 Apr 2009 01:06:58 +0900 Daisuke Nishimura wrote: > A few minor nitpicks :) > > > > +static void memcg_fixup_stale_swapcache(struct work_struct *work) > > > +{ > > > + int pos = 0; > > > + swp_entry_t entry; > > > + struct page *page; > > > + int forget, ret; > > > + > > > + while (ssc.num) { > > > + spin_lock(&ssc.lock); > > > + pos = find_next_bit(ssc.usemap, STALE_ENTS, pos); > > > + spin_unlock(&ssc.lock); > > > + > > > + if (pos >= STALE_ENTS) > > > + break; > > > + > > > + entry = ssc.ents[pos]; > > > + > > > + forget = 1; > > > + page = lookup_swap_cache(entry); > I think using find_get_page() would be better. > lookup_swap_cache() update swapcache_info. > ok, and I have to add put_page() somewhere. > > > + if (page) { > > > + lock_page(page); > > > + ret = try_to_free_swap(page); > > > + /* If it's still under I/O, don't forget it */ > > > + if (!ret && PageWriteback(page)) > > > + forget = 0; > > > + unlock_page(page); > > I think we need page_cache_release(). > > lookup_swap_cache() gets the page. > > > > > + } > > > + if (forget) { > > > + spin_lock(&ssc.lock); > > > + clear_bit(pos, ssc.usemap); > > > + ssc.num--; > > > + if (ssc.num < STALE_ENTS/2) > > > + ssc.congestion = 0; > > > + spin_unlock(&ssc.lock); > > > + } > > > + pos++; > > > + } > > > + if (ssc.num) /* schedule me again */ > > > + schedule_delayed_work(&ssc.gc_work, HZ/10); > We can use schedule_ssc_gc() here. > (It should be defined before this, of course. And can be inlined.) > Sure. will soon post v2. (removing RFC) Thanks, -Kame > > "if (ssc.congestion)" would be better ? > > > > > + return; > > > +} > > > + > > > > Thanks, > Daisuke Nishimura. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/