Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756116AbZD0LoU (ORCPT ); Mon, 27 Apr 2009 07:44:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755958AbZD0LoB (ORCPT ); Mon, 27 Apr 2009 07:44:01 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:49100 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755054AbZD0Ln7 (ORCPT ); Mon, 27 Apr 2009 07:43:59 -0400 Date: Mon, 27 Apr 2009 12:43:57 +0100 From: Mark Brown To: Mike Rapoport Cc: lrg@slimlogic.co.uk, linux-kernel@vger.kernel.org Subject: Re: [PATCH] regulator: add userspace-consumer driver Message-ID: <20090427114357.GA7908@rakim.wolfsonmicro.main> References: <20090426120036.GA10900@opensource.wolfsonmicro.com> <1240753779-28189-1-git-send-email-mike@compulab.co.il> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1240753779-28189-1-git-send-email-mike@compulab.co.il> X-Cookie: But it does move! User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 794 Lines: 17 On Sun, Apr 26, 2009 at 04:49:39PM +0300, Mike Rapoport wrote: > The userspace-consumer driver allows control of voltage and current > regulator state from userspace. This is required for fine-grained > power management of devices that are completely controller by userspace > applications, e.g. a GPS transciever connected to a serial port. > Signed-off-by: Mike Rapoport Looks good, though the probe() and remove() could have __devinit and __devexit annotations. Acked-by: Mark Brown -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/