Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756197AbZD0Mmm (ORCPT ); Mon, 27 Apr 2009 08:42:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753518AbZD0Mmd (ORCPT ); Mon, 27 Apr 2009 08:42:33 -0400 Received: from moutng.kundenserver.de ([212.227.126.186]:53314 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752849AbZD0Mmc convert rfc822-to-8bit (ORCPT ); Mon, 27 Apr 2009 08:42:32 -0400 From: Arnd Bergmann To: monstr@monstr.eu Subject: Re: [PATCH 29/30] microblaze_mmu_v1: stat.h MMU update Date: Mon, 27 Apr 2009 14:42:24 +0200 User-Agent: KMail/1.9.9 Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, john.williams@petalogix.com References: <1240821139-7247-23-git-send-email-monstr@monstr.eu> <200904271357.01681.arnd@arndb.de> <49F5A5B2.7000307@monstr.eu> In-Reply-To: <49F5A5B2.7000307@monstr.eu> X-Face: I@=L^?./?$U,EK.)V[4*>`zSqm0>65YtkOe>TFD'!aw?7OVv#~5xd\s,[~w]-J!)|%=]>=?utf-8?q?+=0A=09=7EohchhkRGW=3F=7C6=5FqTmkd=5Ft=3FLZC=23Q-=60=2E=60Y=2Ea=5E?= =?utf-8?q?3zb?=) =?utf-8?q?+U-JVN=5DWT=25cw=23=5BYo0=267C=26bL12wWGlZi=0A=09=7EJ=3B=5Cwg?= =?utf-8?q?=3B3zRnz?=,J"CT_)=\H'1/{?SR7GDu?WIopm.HaBG=QYj"NZD_[zrM\Gip^U MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Content-Disposition: inline Message-Id: <200904271442.24870.arnd@arndb.de> X-Provags-ID: V01U2FsdGVkX1/bmKjlT6H+Mxp7gGVQ+/hohT6rTU7Nqr8IRob 27kqcW6xUst0tETi/6CN7thm9AofsWAnpBtvCyyt8103Ofz+bu Oa2vhPnbbmrV/E0us/9pw== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 692 Lines: 17 On Monday 27 April 2009, Michal Simek wrote: > > ??????long????????????st_size;????????/* Size of file, in bytes. ?*/ > > Maybe unsigned? Make more sense to me that file size is not minus. > And for some types below. st_size represents an off_t in user space, which is signed. Just over half the existing architectures use signed types for st_size, but for this (like Sam's suggestion for __u64), I don't think it matters either way. Arnd <>< -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/