Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756937AbZD0R0O (ORCPT ); Mon, 27 Apr 2009 13:26:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753033AbZD0RZ6 (ORCPT ); Mon, 27 Apr 2009 13:25:58 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:48178 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751739AbZD0RZ5 (ORCPT ); Mon, 27 Apr 2009 13:25:57 -0400 Date: Mon, 27 Apr 2009 10:06:26 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Tim Abbott cc: Sam Ravnborg , Linux kernel mailing list , Anders Kaseorg , Waseem Daher , Denys Vlasenko , Rusty Russell , Andi Kleen , "H. Peter Anvin" , Stephen Rothwell , Jeff Arnold , Andrew Morton , Jon Masters , Masami Hiramatsu , "Theodore Ts'o" , Nikanth Karthikesan , Arjan van de Ven , Paul Mundt , =?ISO-8859-15?Q?Am=E9rico_Wang?= , Ralf Baechle , Kyle McMartin , David Howells , Russell King , Tony Luck Subject: Re: [PATCH 05/15] arm: convert to use __HEAD and HEAD_TEXT macros. In-Reply-To: Message-ID: References: <1240711870-30505-1-git-send-email-tabbott@mit.edu> <1240711870-30505-2-git-send-email-tabbott@mit.edu> <1240711870-30505-3-git-send-email-tabbott@mit.edu> <1240711870-30505-4-git-send-email-tabbott@mit.edu> <1240711870-30505-5-git-send-email-tabbott@mit.edu> <20090426111924.GD28642@uranus.ravnborg.org> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1458 Lines: 50 On Mon, 27 Apr 2009, Tim Abbott wrote: > > Does .head.text actually need its own output section here? Probably not. Does the ARM build system massage the end result some way looking for that .text.head section in the end? As you note, nobody else cares, and the proper patch may be more along the lines of something below. Of course, most other architectures put the "init" section at the end, and leave the HEAD_TEXT in the regular text section, but I suspect the ARM way of laying things out (init text first) is probably better, since it allows you to free that head code too. Not that it likely much matters. Linus --- arch/arm/kernel/vmlinux.lds.S | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/arch/arm/kernel/vmlinux.lds.S b/arch/arm/kernel/vmlinux.lds.S index c90f272..15520be 100644 --- a/arch/arm/kernel/vmlinux.lds.S +++ b/arch/arm/kernel/vmlinux.lds.S @@ -23,13 +23,11 @@ SECTIONS #else . = PAGE_OFFSET + TEXT_OFFSET; #endif - .text.head : { - _stext = .; - _sinittext = .; - *(.text.head) - } .init : { /* Init code and data */ + _stext = .; + _sinittext = .; + HEAD_TEXT INIT_TEXT _einittext = .; __proc_info_begin = .; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/