Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932298AbZD0Sfl (ORCPT ); Mon, 27 Apr 2009 14:35:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759332AbZD0Sfa (ORCPT ); Mon, 27 Apr 2009 14:35:30 -0400 Received: from pfepa.post.tele.dk ([195.41.46.235]:46697 "EHLO pfepa.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757810AbZD0Sf3 (ORCPT ); Mon, 27 Apr 2009 14:35:29 -0400 Date: Mon, 27 Apr 2009 20:37:38 +0200 From: Sam Ravnborg To: Tim Abbott Cc: Linus Torvalds , Linux kernel mailing list , Anders Kaseorg , Waseem Daher , Denys Vlasenko , Jeff Arnold , Paul Mundt , David Howells Subject: Re: [PATCH 2/8] frv: Use __INIT macro instead of .text.init. Message-ID: <20090427183737.GB12056@uranus.ravnborg.org> References: <1240855347-19316-1-git-send-email-tabbott@mit.edu> <1240855347-19316-2-git-send-email-tabbott@mit.edu> <1240855347-19316-3-git-send-email-tabbott@mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1240855347-19316-3-git-send-email-tabbott@mit.edu> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3588 Lines: 115 On Mon, Apr 27, 2009 at 02:02:21PM -0400, Tim Abbott wrote: > frv is placing some code in the .text.init section but does not > reference that section in its linker scripts. > > This change moves this code from the .text.init section to the > .init.text section, which is presumably where it belongs. I checked a few of the assembler entries - they where all called from __HEAD section. So this change looks good. > > Signed-off-by: Tim Abbott > Cc: David Howells Acked-by: Sam Ravnborg > --- > arch/frv/kernel/head-mmu-fr451.S | 3 ++- > arch/frv/kernel/head-uc-fr401.S | 3 ++- > arch/frv/kernel/head-uc-fr451.S | 3 ++- > arch/frv/kernel/head-uc-fr555.S | 3 ++- > 4 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/arch/frv/kernel/head-mmu-fr451.S b/arch/frv/kernel/head-mmu-fr451.S > index c8f210d..98f87d5 100644 > --- a/arch/frv/kernel/head-mmu-fr451.S > +++ b/arch/frv/kernel/head-mmu-fr451.S > @@ -9,6 +9,7 @@ > * 2 of the License, or (at your option) any later version. > */ > > +#include > #include > #include > #include > @@ -31,7 +32,7 @@ > #define __400_LCR 0xfe000100 > #define __400_LSBR 0xfe000c00 > > - .section .text.init,"ax" > + __INIT > .balign 4 > > ############################################################################### > diff --git a/arch/frv/kernel/head-uc-fr401.S b/arch/frv/kernel/head-uc-fr401.S > index ee282be..438643c 100644 > --- a/arch/frv/kernel/head-uc-fr401.S > +++ b/arch/frv/kernel/head-uc-fr401.S > @@ -9,6 +9,7 @@ > * 2 of the License, or (at your option) any later version. > */ > > +#include > #include > #include > #include > @@ -30,7 +31,7 @@ > #define __400_LCR 0xfe000100 > #define __400_LSBR 0xfe000c00 > > - .section .text.init,"ax" > + __INIT > .balign 4 > > ############################################################################### > diff --git a/arch/frv/kernel/head-uc-fr451.S b/arch/frv/kernel/head-uc-fr451.S > index b10d9c8..b2a76c4 100644 > --- a/arch/frv/kernel/head-uc-fr451.S > +++ b/arch/frv/kernel/head-uc-fr451.S > @@ -9,6 +9,7 @@ > * 2 of the License, or (at your option) any later version. > */ > > +#include > #include > #include > #include > @@ -30,7 +31,7 @@ > #define __400_LCR 0xfe000100 > #define __400_LSBR 0xfe000c00 > > - .section .text.init,"ax" > + __INIT > .balign 4 > > ############################################################################### > diff --git a/arch/frv/kernel/head-uc-fr555.S b/arch/frv/kernel/head-uc-fr555.S > index 39937c1..5497aaf 100644 > --- a/arch/frv/kernel/head-uc-fr555.S > +++ b/arch/frv/kernel/head-uc-fr555.S > @@ -9,6 +9,7 @@ > * 2 of the License, or (at your option) any later version. > */ > > +#include > #include > #include > #include > @@ -29,7 +30,7 @@ > #define __551_LCR 0xfeff1100 > #define __551_LSBR 0xfeff1c00 > > - .section .text.init,"ax" > + __INIT > .balign 4 > > ############################################################################### > -- > 1.6.2.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/