Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758077AbZD0TxT (ORCPT ); Mon, 27 Apr 2009 15:53:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751629AbZD0TxI (ORCPT ); Mon, 27 Apr 2009 15:53:08 -0400 Received: from mx2.redhat.com ([66.187.237.31]:58310 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751012AbZD0TxH (ORCPT ); Mon, 27 Apr 2009 15:53:07 -0400 Date: Mon, 27 Apr 2009 21:48:45 +0200 From: Oleg Nesterov To: Andrew Morton Cc: Roland McGrath , linux-kernel@vger.kernel.org Subject: [PATCH] copy_process: remove the unneeded clear_tsk_thread_flag(TIF_SIGPENDING) Message-ID: <20090427194845.GA6245@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 863 Lines: 22 The forked child can have TIF_SIGPENDING if it was copied from parent's ti->flags. But this is harmless and actually almost never happens, because copy_process() can't succeed if signal_pending() == T. Signed-off-by: Oleg Nesterov --- PTRACE/kernel/fork.c~FORK_SIGPENDING 2009-04-13 17:05:52.000000000 +0200 +++ PTRACE/kernel/fork.c 2009-04-27 21:38:57.000000000 +0200 @@ -1027,7 +1027,6 @@ static struct task_struct *copy_process( p->vfork_done = NULL; spin_lock_init(&p->alloc_lock); - clear_tsk_thread_flag(p, TIF_SIGPENDING); init_sigpending(&p->pending); p->utime = cputime_zero; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/