Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759257AbZD0Tx5 (ORCPT ); Mon, 27 Apr 2009 15:53:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752897AbZD0Txs (ORCPT ); Mon, 27 Apr 2009 15:53:48 -0400 Received: from outbound-mail-25.bluehost.com ([69.89.21.20]:33384 "HELO outbound-mail-25.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751629AbZD0Txs (ORCPT ); Mon, 27 Apr 2009 15:53:48 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=virtuousgeek.org; h=Received:Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:X-Mailer:Mime-Version:Content-Type:Content-Transfer-Encoding:X-Identified-User; b=gyhwQFIwgnqnk+yobkxPwnxpG9raipfqIoeaRWmIQNMCplQUIYn7UuwylQbNWJy+oo1RgZDYSsVNGgcrKDlPUpyjnZGKmV8gzKosYU5JJrPz6lk/IBtdPxrotnwpDs9l; Date: Mon, 27 Apr 2009 12:53:42 -0700 From: Jesse Barnes To: Bjorn Helgaas Cc: Yinghai Lu , Ingo Molnar , "H. Peter Anvin" , Thomas Gleixner , "linux-kernel@vger.kernel.org" , linux-pci@vger.kernel.org, Gary Hade , Alex Chiang , linux-acpi@vger.kernel.org, Matthew Wilcox Subject: Re: [PATCH] x86/pci: do assign root bus res if _CRS is used Message-ID: <20090427125342.7ec0e116@hobbes> In-Reply-To: <200904271344.04099.bjorn.helgaas@hp.com> References: <49ED22EC.2040204@kernel.org> <200904271344.04099.bjorn.helgaas@hp.com> X-Mailer: Claws Mail 3.7.1 (GTK+ 2.16.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Identified-User: {10642:box514.bluehost.com:virtuous:virtuousgeek.org} {sentby:smtp auth 75.111.28.251 authed with jbarnes@virtuousgeek.org} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2099 Lines: 56 On Mon, 27 Apr 2009 13:44:01 -0600 Bjorn Helgaas wrote: > On Monday 20 April 2009 07:35:40 pm Yinghai Lu wrote: > > it wil be overwriten later if _CRS is used, so don't bother to set > > it. > > > > [ Impact: cleanup ] > > > > Signed-off-by: Yinghai Lu > > > > --- > > arch/x86/pci/amd_bus.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > Index: linux-2.6/arch/x86/pci/amd_bus.c > > =================================================================== > > --- linux-2.6.orig/arch/x86/pci/amd_bus.c > > +++ linux-2.6/arch/x86/pci/amd_bus.c > > @@ -100,6 +100,10 @@ void x86_pci_root_bus_res_quirks(struct > > int j; > > struct pci_root_info *info; > > > > + /* don't go for it if _CRS is used */ > > + if (pci_probe & PCI_USE__CRS) > > + return; > > + > > /* if only one root bus, don't need to anything */ > > if (pci_root_num < 2) > > return; > > This isn't a comment on this patch per se. > > I am concerned about the fact that "pci=use_crs" is not the default. > From the changelog of 62f420f8282, it sounds like you have to boot an > IBM x3850 with "pci=use_crs" to make hot-plug work, even though ACPI > tells us everything we need to know. That's backwards. > > We shouldn't need an option to tell Linux that the firmware is > trustworthy. We should have an option to *ignore* it for the times > when we trip over something broken and haven't figured out a way to > work around it yet. Well, we could try using _CRS by default, but like many things ACPI we can probably only trust firmwares after a certain date (i.e. the date when Windows started relying on the data being correct in order to boot). Do we have a good cutoff for that? Or should we try generally enabling it early in 2.6.31 to see what happens? -- Jesse Barnes, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/