DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=Q3h+7FFSCvd7u95nbPXC4oK8VqNDBCsmVdajnnQFuC+C4fnSArMxjNsu23V/auP3JYU2KE+ZmtUMh/01BFSGb8rGWfj5m4KdVWIiZRdgNIL5lQRxvhdfrjaWs9URuxfm+K62lT5DPUEadv48iPbieT3K4AT+Lq09CwrDZjFWfOM=  ;
From: David Brownell <david-b@pacbell.net>
To: Paul Walmsley <paul@pwsan.com>
Subject: Re: [PATCH] regulator core: fix double-free in regulator_register() error path
Date: Mon, 27 Apr 2009 20:08:50 -0700
User-Agent: KMail/1.9.10
Cc: linux-omap@vger.kernel.org, lrg@slimlogic.co.uk,
       broonie@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org
References: <alpine.DEB.2.00.0904250526210.28378@utopia.booyaka.com> <alpine.DEB.2.00.0904252250230.4291@utopia.booyaka.com>
In-Reply-To: <alpine.DEB.2.00.0904252250230.4291@utopia.booyaka.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Message-Id: <200904272008.50268.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1139
Lines: 27

On Saturday 25 April 2009, Paul Walmsley wrote:
> 
> > device_unregister() calls regulator_dev_release() which frees rdev. ?The 
> > subsequent kfree corrupts memory and causes some OMAP3 systems to oops on 
> > boot in regulator_get().
> 
> For the 3430SDP users out there, this patch also fixes the boot hang after 
> "regulator_init_complete: incomplete constraints, leaving VAUX3 on"
> on that device.

For the record, that "incomplete constraints" message is bogus.
On that board, VAUX3 has a complete set of constraints:  it may
only emit 2.8V.

What it lacks is something entirely different:  driver support
for the LCD which uses the regulator framework, instead of just
bypassing it and talking directly to the PMIC.  By the time it
gets there, the LCD has probably been turned on.

Mark and/or Liam ... you might want to fix that diagnostic, to
avoid leading more developers astray!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/