Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754224AbZD1EVG (ORCPT ); Tue, 28 Apr 2009 00:21:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750829AbZD1EUx (ORCPT ); Tue, 28 Apr 2009 00:20:53 -0400 Received: from BISCAYNE-ONE-STATION.MIT.EDU ([18.7.7.80]:42520 "EHLO biscayne-one-station.mit.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750735AbZD1EUx (ORCPT ); Tue, 28 Apr 2009 00:20:53 -0400 Date: Tue, 28 Apr 2009 00:20:47 -0400 (EDT) From: Tim Abbott To: Sam Ravnborg cc: Linus Torvalds , Linux kernel mailing list , Anders Kaseorg , Waseem Daher , Denys Vlasenko , Jeff Arnold , Paul Mundt , Benjamin Herrenschmidt Subject: Re: [PATCH 11/14] powerpc: Use macros for .data.page_aligned section. In-Reply-To: <1240864388-26315-12-git-send-email-tabbott@mit.edu> Message-ID: References: <1240864388-26315-1-git-send-email-tabbott@mit.edu> <1240864388-26315-2-git-send-email-tabbott@mit.edu> <1240864388-26315-3-git-send-email-tabbott@mit.edu> <1240864388-26315-4-git-send-email-tabbott@mit.edu> <1240864388-26315-5-git-send-email-tabbott@mit.edu> <1240864388-26315-6-git-send-email-tabbott@mit.edu> <1240864388-26315-7-git-send-email-tabbott@mit.edu> <1240864388-26315-8-git-send-email-tabbott@mit.edu> <1240864388-26315-9-git-send-email-tabbott@mit.edu> <1240864388-26315-10-git-send-email-tabbott@mit.edu> <1240864388-26315-11-git-send-email-tabbott@mit.edu> <1240864388-26315-12-git-send-email-tabbott@mit.edu> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Flag: NO X-Spam-Score: 0.00 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 809 Lines: 24 On Mon, 27 Apr 2009, Tim Abbott wrote: > +++ b/arch/powerpc/kernel/vmlinux.lds.S > @@ -222,6 +222,7 @@ SECTIONS > > #ifdef CONFIG_PPC32 > .data : AT(ADDR(.data) - LOAD_OFFSET) { > + PAGE_ALIGNED_DATA > DATA_DATA > *(.sdata) > *(.got.plt) *(.got) Just noticed that PAGE_ALIGNED_DATA is only being added for CONFIG_PPC32. Since there will be several more FOO_DATA macros being added to the .data section, I think the right fix is to first unify the two .data output section definitions, and then convert to using PAGE_ALIGNED_DATA. -Tim Abbott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/