Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756619AbZD1JPy (ORCPT ); Tue, 28 Apr 2009 05:15:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755062AbZD1JPn (ORCPT ); Tue, 28 Apr 2009 05:15:43 -0400 Received: from mail-fx0-f158.google.com ([209.85.220.158]:38881 "EHLO mail-fx0-f158.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754970AbZD1JPm (ORCPT ); Tue, 28 Apr 2009 05:15:42 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=RzrJs8GXaEnAjD+SulI5k3eZapUXxgfTD4QrS7LOX+y1VOtsQ+2m5Fs3fFA1uRmRFW +KRh3fahZF8ifsyvvtqrTnyDUVKSb89L7w/kx8LtX51XUFoqA3zBeL0EMjQdn3OkMD8M /yrOX0OWG/tzFx5m1EGeeo9MMas22QcdyG+eQ= MIME-Version: 1.0 In-Reply-To: <20090428091034.GL27382@one.firstfloor.org> References: <20090428010907.912554629@intel.com> <20090428014920.769723618@intel.com> <20090428065507.GA2024@elte.hu> <20090428074031.GK27382@one.firstfloor.org> <1240909484.1982.16.camel@penberg-laptop> <20090428091034.GL27382@one.firstfloor.org> Date: Tue, 28 Apr 2009 12:15:41 +0300 X-Google-Sender-Auth: 090fadf4074ed73d Message-ID: <84144f020904280215k6e2ae34dk8f1a14a51be2e203@mail.gmail.com> Subject: Re: [PATCH 5/5] proc: export more page flags in /proc/kpageflags From: Pekka Enberg To: Andi Kleen Cc: Ingo Molnar , Wu Fengguang , Steven Rostedt , =?ISO-8859-1?Q?Fr=E9d=E9ric_Weisbecker?= , Larry Woodman , Peter Zijlstra , Eduard - Gabriel Munteanu , Andrew Morton , LKML , KOSAKI Motohiro , Matt Mackall , Alexey Dobriyan , "linux-mm@kvack.org" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1380 Lines: 32 Hi Andi, On Tue, Apr 28, 2009 at 12:10 PM, Andi Kleen wrote: >> Yes, zero overhead is important for certain things (like >> CONFIG_SLUB_STATS, for example). However, putting slab allocator >> specific checks in fs/proc looks pretty fragile to me. It would be nice > > Ok, perhaps that could be put into a inline into slab.h. Would > that address your concerns? Yeah, I'm fine with that. Putting them in the individual slub_def.h/slob_def.h headers might be even better. On Tue, Apr 28, 2009 at 12:10 PM, Andi Kleen wrote: >> Also, while you probably don't want to use tracepoints for this kind of >> instrumentation, you might want to look into reusing the ftrace >> reporting bits. > > There's already perfectly fine code in tree for this, I don't see why it would > need another infrastructure that doesn't really fit anyways. It's just that I suspect that we want page flag printing and zero-overhead statistics for kmemtrace at some point. But anyway, I'm not objecting to extending /proc/kpageflags if that's what people want to do. Pekka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/