Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757363AbZD1JbY (ORCPT ); Tue, 28 Apr 2009 05:31:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754513AbZD1JbA (ORCPT ); Tue, 28 Apr 2009 05:31:00 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:56846 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1754170AbZD1Ja7 (ORCPT ); Tue, 28 Apr 2009 05:30:59 -0400 Date: Tue, 28 Apr 2009 02:30:52 -0700 (PDT) Message-Id: <20090428.023052.98414161.davem@davemloft.net> To: alex.williamson@hp.com Cc: rusty@rustcorp.com.au, sfr@canb.auug.org.au, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-next@vger.kernel.org Subject: Re: [PATCH] virtio_net: Cleanup command queue scatterlist usage From: David Miller In-Reply-To: <20090427154925.4771.63651.stgit@debian.lart> References: <20090426.233014.216353908.davem@davemloft.net> <20090427154925.4771.63651.stgit@debian.lart> X-Mailer: Mew version 6.2.51 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 661 Lines: 16 From: Alex Williamson Date: Mon, 27 Apr 2009 09:50:03 -0600 > We were avoiding calling sg_init* on scatterlists passed > into virtnet_send_command to prevent extraneous end markers. > This caused build warnings for uninitialized variables. > Cleanup the code to create proper scatterlists. > > Signed-off-by: Alex Williamson Looks good to me, what say you Rusty? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/