Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760282AbZD1MrR (ORCPT ); Tue, 28 Apr 2009 08:47:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760042AbZD1Mqs (ORCPT ); Tue, 28 Apr 2009 08:46:48 -0400 Received: from mx2.redhat.com ([66.187.237.31]:43172 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760116AbZD1Mqr (ORCPT ); Tue, 28 Apr 2009 08:46:47 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <1240864388-26315-4-git-send-email-tabbott@mit.edu> <1240864388-26315-1-git-send-email-tabbott@mit.edu> <1240864388-26315-2-git-send-email-tabbott@mit.edu> <1240864388-26315-3-git-send-email-tabbott@mit.edu> <4678.1240875782@redhat.com> To: Tim Abbott Cc: dhowells@redhat.com, Sam Ravnborg , Linus Torvalds , Linux kernel mailing list , Anders Kaseorg , Waseem Daher , Denys Vlasenko , Jeff Arnold , Paul Mundt Subject: Re: [PATCH 03/14] mn10300: Use macros for .bss.page_aligned section. Date: Tue, 28 Apr 2009 13:45:36 +0100 Message-ID: <31713.1240922736@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1358 Lines: 52 Tim Abbott wrote: > No, it is. The macro is new in PATCH 1/14 of this series. Aha! Okay, I've applied that patch too, and now I see: LD .tmp_vmlinux1 /opt/nickc/H-i686-pc-linux-gnulibc2.3/bin/am33_2.0-linux-gnu-ld:arch/mn10300/kernel/vmlinux.lds:237: syntax error Where the error occurs on line 237, which is: __bss_start = .; /* BSS */ .bss : { . = ALIGN(+(1 << 12)) *(.bss.page_aligned) *(.bss) ==> } . = ALIGN(4); __bss_stop = .; in the expanded linker script. The problem is that your patch #1 is wrong. You need to apply: --- diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h index a76275f..c9b16a6 100644 --- a/include/asm-generic/vmlinux.lds.h +++ b/include/asm-generic/vmlinux.lds.h @@ -118,11 +118,11 @@ TRACE_SYSCALLS() #define PAGE_ALIGNED_DATA \ - . = ALIGN(PAGE_SIZE) \ + . = ALIGN(PAGE_SIZE); \ *(.data.page_aligned) #define PAGE_ALIGNED_BSS \ - . = ALIGN(PAGE_SIZE) \ + . = ALIGN(PAGE_SIZE); \ *(.bss.page_aligned) #define RO_DATA(align) \ --- to it. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/