Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761393AbZD1NoA (ORCPT ); Tue, 28 Apr 2009 09:44:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756558AbZD1Nnr (ORCPT ); Tue, 28 Apr 2009 09:43:47 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:57264 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753544AbZD1Nnq (ORCPT ); Tue, 28 Apr 2009 09:43:46 -0400 Date: Tue, 28 Apr 2009 06:43:40 -0700 (PDT) Message-Id: <20090428.064340.193569214.davem@davemloft.net> To: mingo@elte.hu Cc: dada1@cosmosbay.com, torvalds@linux-foundation.org, shemminger@vyatta.com, zbr@ioremap.net, peterz@infradead.org, mathieu.desnoyers@polymtl.ca, jarkao2@gmail.com, paulus@samba.org, paulmck@linux.vnet.ibm.com, kaber@trash.net, jeff.chua.linux@gmail.com, laijs@cn.fujitsu.com, jengelh@medozas.de, r000n@r000n.net, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, benh@kernel.crashing.org Subject: Re: [PATCH] netfilter: use per-CPU r**ursive lock {XV} From: David Miller In-Reply-To: <20090428124033.GA1655@elte.hu> References: <49F6A8FD.3010804@cosmosbay.com> <20090428.045342.206106171.davem@davemloft.net> <20090428124033.GA1655@elte.hu> X-Mailer: Mew version 6.2.51 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 721 Lines: 18 From: Ingo Molnar Date: Tue, 28 Apr 2009 14:40:33 +0200 > IMHO this locking construct should be considered for > linux/local_lock.h and kernel/local_lock.c. Even if the netfilter > code drops its use soon afterwards ;-) If you can show me have to pass a per-cpu variable (the variable, not a dereference of it) as an argument to an inline function, I'll implement this :-) It has to be dereferenced after local_bh_disable() for the read side acquisition. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/