Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760353AbZD1P0i (ORCPT ); Tue, 28 Apr 2009 11:26:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762639AbZD1PXf (ORCPT ); Tue, 28 Apr 2009 11:23:35 -0400 Received: from hera.kernel.org ([140.211.167.34]:59328 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762595AbZD1PXc (ORCPT ); Tue, 28 Apr 2009 11:23:32 -0400 Message-ID: <49F71EF6.3050102@kernel.org> Date: Tue, 28 Apr 2009 08:21:26 -0700 From: Yinghai Lu User-Agent: Thunderbird 2.0.0.19 (X11/20081227) MIME-Version: 1.0 To: Kay Sievers CC: Ingo Molnar , Greg KH , Linus Torvalds , Jesse Barnes , Andrew Morton , "H. Peter Anvin" , Thomas Gleixner , "linux-kernel@vger.kernel.org" , linux-pci@vger.kernel.org Subject: Re: [RFC PATCH] use dev_set_name(,NULL) to prevent leaking References: <20090416235452.GE21405@elte.hu> <49EA27B9.3030004@kernel.org> <20090418192314.GA22107@suse.de> <1240086446.2411.9.camel@poy> <20090418203718.GD30144@elte.hu> <49EA4EB9.2030307@kernel.org> <49F6B1E6.7050008@kernel.org> <49F6B350.9080703@kernel.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 691 Lines: 18 Kay Sievers wrote: > On Tue, Apr 28, 2009 at 09:42, Yinghai Lu wrote: >> those about 1/3 dev_set_name() etc. > > put_device()? > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=drivers/base/core.c;h=4aa527b8a91381289eb175b33f46e3e418d10374;hb=HEAD#l848 > ok, normal release path seems right, put_device will free the name. how about other fail path, that there is not put_device involved? YH -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/