Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763584AbZD1RwW (ORCPT ); Tue, 28 Apr 2009 13:52:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757738AbZD1RwH (ORCPT ); Tue, 28 Apr 2009 13:52:07 -0400 Received: from acsinet12.oracle.com ([141.146.126.234]:56557 "EHLO acsinet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753138AbZD1RwF (ORCPT ); Tue, 28 Apr 2009 13:52:05 -0400 Message-ID: <49F7421A.1090709@oracle.com> Date: Tue, 28 Apr 2009 10:51:22 -0700 From: Randy Dunlap Organization: Oracle Linux Engineering User-Agent: Thunderbird 2.0.0.6 (X11/20070801) MIME-Version: 1.0 To: "J. Bruce Fields" CC: Stephen Rothwell , linux-next@vger.kernel.org, LKML , Andrew Morton , Matthew Wilcox , linux-fsdevel Subject: Re: [PATCH] lockd: fix FILE_LOCKING=n build error References: <20090428165343.2e357d7a.sfr@canb.auug.org.au> <49F71F4A.3080908@oracle.com> <20090428172137.GA22451@fieldses.org> In-Reply-To: <20090428172137.GA22451@fieldses.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Source-IP: acsmt706.oracle.com [141.146.40.84] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A010203.49F741D1.00DF:SCFMA4539814,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2182 Lines: 70 J. Bruce Fields wrote: > On Tue, Apr 28, 2009 at 08:22:50AM -0700, Randy Dunlap wrote: >> From: Randy Dunlap >> >> lockd/svclock.c is missing a header file . >> >> is missing a definition of locks_release_private() >> for the config case of FILE_LOCKING=n, causing a build error: >> >> fs/lockd/svclock.c:330: error: implicit declaration of function 'locks_release_private' > > LOCKD without FILE_LOCKING doesn't really make sense; would it be better > to add a config dependency? I just tried a patch like the one below instead of the first one, but it has build errors too, so more Makefile/Kconfig work is needed (by someone who knows what interfaces are needed here): fs/built-in.o: In function `nfs_start_lockd': client.c:(.text+0xe8848): undefined reference to `nlmclnt_init' fs/built-in.o: In function `nfs_destroy_server': client.c:(.text+0xe8885): undefined reference to `nlmclnt_done' fs/built-in.o: In function `nfs_proc_lock': proc.c:(.text+0xf735f): undefined reference to `nlmclnt_proc' fs/built-in.o: In function `nfs3_proc_lock': nfs3proc.c:(.text+0xfd1df): undefined reference to `nlmclnt_proc' lockd without FILE_LOCKING doesn't make sense, so make LOCKD and LOCKD_V4 depend on FILE_LOCKING. --- fs/Kconfig | 2 ++ fs/nfs/Kconfig | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) --- linux-next-20090428.orig/fs/Kconfig +++ linux-next-20090428/fs/Kconfig @@ -226,10 +226,12 @@ source "fs/nfsd/Kconfig" config LOCKD tristate + depends on FILE_LOCKING config LOCKD_V4 bool depends on NFSD_V3 || NFS_V3 + depends on FILE_LOCKING default y config EXPORTFS --- linux-next-20090428.orig/fs/nfs/Kconfig +++ linux-next-20090428/fs/nfs/Kconfig @@ -1,7 +1,7 @@ config NFS_FS tristate "NFS client support" depends on INET - select LOCKD + select LOCKD if FILE_LOCKING select SUNRPC select NFS_ACL_SUPPORT if NFS_V3_ACL help -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/