Subject: Re: [PATCH RFC] ext3 data=guarded v5
From: Chris Mason <chris.mason@oracle.com>
To: Mike Galbraith <efault@gmx.de>
Cc: Jan Kara <jack@suse.cz>, Linus Torvalds <torvalds@linux-foundation.org>,
       "Theodore Ts'o" <tytso@mit.edu>,
       Linux Kernel Developers List <linux-kernel@vger.kernel.org>,
       Ext4 Developers List <linux-ext4@vger.kernel.org>
In-Reply-To: <1240943582.5611.15.camel@marge.simson.net>
References: <1240941840.15136.44.camel@think.oraclecorp.com>
	 <1240943582.5611.15.camel@marge.simson.net>
Content-Type: text/plain
Date: Tue, 28 Apr 2009 14:54:14 -0400
Message-Id: <1240944854.15136.46.camel@think.oraclecorp.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 892
Lines: 23

On Tue, 2009-04-28 at 20:33 +0200, Mike Galbraith wrote:
> On Tue, 2009-04-28 at 14:04 -0400, Chris Mason wrote:
> 
> > This patch adds the delayed i_size update to ext3, along with a new
> > mount option (data=guarded) to enable it.
> 
> Is there a good reason to require a new mount option for this vs just
> calling it a fix (or enhancement) to the existing writeback option?
> 
> I presume yes (you are fs guy..), but wonder what that reason is.

It is mostly cutting down on the risk of the patch.  The patch tries to
isolate its changes to just data=guarded mode, so you can go back to the
old and crusty modes if things go badly.

-chris


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/