Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754352AbZD2Fq6 (ORCPT ); Wed, 29 Apr 2009 01:46:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752331AbZD2Fqs (ORCPT ); Wed, 29 Apr 2009 01:46:48 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:41205 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751732AbZD2Fqs (ORCPT ); Wed, 29 Apr 2009 01:46:48 -0400 Date: Tue, 28 Apr 2009 22:44:31 -0700 From: Andrew Morton To: monstr@monstr.eu Cc: linux-kernel@vger.kernel.org, john.williams@petalogix.com Subject: Re: [PATCH 08/30] microblaze_mmu_v1: mmu.h update Message-Id: <20090428224431.3cd75346.akpm@linux-foundation.org> In-Reply-To: <1240821139-7247-9-git-send-email-monstr@monstr.eu> References: <1240821139-7247-1-git-send-email-monstr@monstr.eu> <1240821139-7247-2-git-send-email-monstr@monstr.eu> <1240821139-7247-3-git-send-email-monstr@monstr.eu> <1240821139-7247-4-git-send-email-monstr@monstr.eu> <1240821139-7247-5-git-send-email-monstr@monstr.eu> <1240821139-7247-6-git-send-email-monstr@monstr.eu> <1240821139-7247-7-git-send-email-monstr@monstr.eu> <1240821139-7247-8-git-send-email-monstr@monstr.eu> <1240821139-7247-9-git-send-email-monstr@monstr.eu> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 514 Lines: 14 On Mon, 27 Apr 2009 10:31:57 +0200 monstr@monstr.eu wrote: > +extern PTE *Hash, *Hash_end; > +extern unsigned long Hash_size, Hash_mask; These are global symbols? There's some namespace collision risk here. `microblaze_mmu_hash' or whatever would be a safer change. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/