Return-Path: <linux-kernel-owner+w=401wt.eu-S1755061AbZD2IWZ@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755061AbZD2IWZ (ORCPT <rfc822;w@1wt.eu>);
	Wed, 29 Apr 2009 04:22:25 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752219AbZD2IWK
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 29 Apr 2009 04:22:10 -0400
Received: from smtp1.linux-foundation.org ([140.211.169.13]:55432 "EHLO
	smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1752277AbZD2IWG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 29 Apr 2009 04:22:06 -0400
Date: Wed, 29 Apr 2009 01:17:55 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Mike Galbraith <efault@gmx.de>
Cc: Martin Knoblauch <knobi@knobisoft.de>, "Rafael J. Wysocki" <rjw@sisk.pl>,
       linux-kernel@vger.kernel.org,
       tigran aivazian <tigran@aivazian.fsnet.co.uk>,
       Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: Analyzed/Solved: Booting 2.6.30-rc2-git7 very slow
Message-Id: <20090429011755.c141c599.akpm@linux-foundation.org>
In-Reply-To: <1240977096.5478.3.camel@marge.simson.net>
References: <409142.83316.qm@web32605.mail.mud.yahoo.com>
	<20090428182837.62c51f26.akpm@linux-foundation.org>
	<1240977096.5478.3.camel@marge.simson.net>
X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1893
Lines: 43

On Wed, 29 Apr 2009 05:51:36 +0200 Mike Galbraith <efault@gmx.de> wrote:

> On Tue, 2009-04-28 at 18:28 -0700, Andrew Morton wrote: 
> > On Fri, 24 Apr 2009 05:45:19 -0700 (PDT) Martin Knoblauch <knobi@knobisoft.de> wrote:
> > 
> > > 
> > > 
> > >  OK, I just found the reason for both intel-ucode and tg3 failures. Apparently between 2.6.28 and 2.6.29 the mount of sysfs has subtely changed from:
> > > 
> > > /sys /sys sysfs rw 0 0
> > > 
> > > to:
> > > 
> > > none /sys sysfs rw,relatime 0 0
> > 
> > I assume that you're referring to the contents of /proc/mounts?
> > 
> > >  The "none" breaks the RHEL-4 provided hotplug script "firmware.agent" when it tries to parse the mount point for "/sys". As a result, the firmware loading is never properly finished and the driver(s) just timeout on the value  in /sys/class/firmware/timeout. Bingo. Simple fix in user-pace possible - cool down Martin :-)
> > > 
> > > Questions remains: was this intentional? It breaks existing userspace and should therefore be considered a regression - right? On the other hand, it will never be a problem for RHEL-4/5 kernels, unless the change in 2.6.29 gets backported. Any ideas?
> > 
> > afaik that was unintentional and was probably a mistake.
> > 
> > I wonder how we did that.
> 
> <paste>
> > [hotplug]# grep sysfs /proc/mounts
> > none /sys sysfs rw,relatime 0 0
> > /sys /sys sysfs rw,relatime 0 0
> 
> ___(I wonder how the heck that is accomplished)
> 

Beats me.  I'm not seeing likely changes in fs/proc/base.c or around
show_mountinfo().  Maybe sysfs broke in an ingenious way.  (hopefully
cc's viro).

Displaying relatime seems a bit pointless too.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/