Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756670AbZD2JZy (ORCPT ); Wed, 29 Apr 2009 05:25:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750834AbZD2JZk (ORCPT ); Wed, 29 Apr 2009 05:25:40 -0400 Received: from vervifontaine.sonytel.be ([80.88.33.193]:44258 "EHLO pophost.sonytel.be" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750795AbZD2JZj (ORCPT ); Wed, 29 Apr 2009 05:25:39 -0400 Date: Wed, 29 Apr 2009 11:25:32 +0200 (CEST) From: Geert Uytterhoeven To: Tejun Heo cc: axboe@kernel.dk, Linux Kernel Development , linux-scsi@vger.kernel.org, jeff@garzik.org, linux-ide@vger.kernel.org, "James E.J. Bottomley" , bzolnier@gmail.com, petkovbb@googlemail.com, sshtylyov@ru.mvista.com, mike.miller@hp.com, chirag.kantharia@hp.com, Eric.Moore@lsi.com, stern@rowland.harvard.edu, fujita.tomonori@lab.ntt.co.jp, zaitcev@redhat.com, sfr@canb.auug.org.au, grant.likely@secretlab.ca, paul.clements@steeleye.com, jesper.juhl@gmail.com, tim@cyberelk.net, jeremy@xensource.com, adrian@mcmen.demon.co.uk, oakad@yahoo.com, David Woodhouse , schwidefsky@de.ibm.com, ballabio_dario@emc.com, "David S. Miller" , Paul Russell , Markus.Lidel@shadowconnect.com, bharrosh@panasas.com Subject: Re: [PATCH 04/10] block: implement blk_rq_pos/[cur_]sectors() and convert obvious ones In-Reply-To: <1240996428-10159-5-git-send-email-tj@kernel.org> Message-ID: References: <1240996428-10159-1-git-send-email-tj@kernel.org> <1240996428-10159-5-git-send-email-tj@kernel.org> User-Agent: Alpine 2.00 (LRH 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=ISO-8859-15 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2573 Lines: 79 On Wed, 29 Apr 2009, Tejun Heo wrote: > Implement accessors - blk_rq_pos(), blk_rq_sectors() and > blk_rq_cur_sectors() which return rq->sector, rq->hard_nr_sectors and > rq->hard_cur_sectors respectively and convert direct references of the > said fields to the accessors. > > This is in preparation of request data length handling cleanup. > > [ Impact: cleanup ] > > Signed-off-by: Tejun Heo > Cc: Geert Uytterhoeven > drivers/block/ps3disk.c | 2 +- Acked-by: Geert Uytterhoeven > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -832,13 +832,30 @@ static inline void blk_run_address_space(struct address_space *mapping) > extern void blkdev_dequeue_request(struct request *req); > > /* > - * blk_end_request() takes bytes instead of sectors as a complete size. > - * blk_rq_bytes() returns bytes left to complete in the entire request. > - * blk_rq_cur_bytes() returns bytes left to complete in the current segment. > + * blk_rq_pos() : the current sector > + * blk_rq_bytes() : bytes left in the entire request > + * blk_rq_cur_bytes() : bytes left in the current segment > + * blk_rq_sectors() : sectors left in the entire request > + * blk_rq_cur_sectors() : sectors left in the current segment > */ > +static inline sector_t blk_rq_pos(struct request *rq) ^ const? > +{ > + return rq->hard_sector; > +} > + > extern unsigned int blk_rq_bytes(struct request *rq); > extern unsigned int blk_rq_cur_bytes(struct request *rq); > > +static inline unsigned int blk_rq_sectors(struct request *rq) ^ const? > +{ > + return rq->hard_nr_sectors; > +} > + > +static inline unsigned int blk_rq_cur_sectors(struct request *rq) ^ const? > +{ > + return rq->hard_cur_sectors; > +} > + With kind regards, Geert Uytterhoeven Software Architect Techsoft Centre Technology and Software Centre Europe The Corporate Village ? Da Vincilaan 7-D1 ? B-1935 Zaventem ? Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven@sonycom.com Internet: http://www.sony-europe.com/ A division of Sony Europe (Belgium) N.V. VAT BE 0413.825.160 ? RPR Brussels Fortis ? BIC GEBABEBB ? IBAN BE41293037680010 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/