Date: Wed, 29 Apr 2009 12:36:55 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Tom Zanussi <tzanussi@gmail.com>, LKML <linux-kernel@vger.kernel.org>,
       Steven Rostedt <rostedt@goodmis.org>, fweisbec@gmail.com,
       Li Zefan <lizf@cn.fujitsu.com>
Subject: Re: [PATCH 2/3] tracing/filters: distinguish between signed and
	unsigned fields
Message-ID: <20090429103655.GD2373@elte.hu>
References: <1240905893.6416.120.camel@tropicana> <20090428234645.c1780736.akpm@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090428234645.c1780736.akpm@linux-foundation.org>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 776
Lines: 31


* Andrew Morton <akpm@linux-foundation.org> wrote:

> On Tue, 28 Apr 2009 03:04:53 -0500 Tom Zanussi <tzanussi@gmail.com> wrote:
> 
> > +#define is_signed(t)	(((t)-1) < 0)
> 
> geeze that was confusing until I worked out that `t' is supposed to be
> the name of a C type.

good point, i've changed its name to is_signed_type().

> 	is_signed(0) == true!
> 
> whee.

I also added parantheses around the -1 literal to make it clear that 
this is a cast.

> Rename it to is_signed_type() or something, please?

done.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/