From: Arnd Bergmann <arnd@arndb.de>
To: monstr@monstr.eu
Subject: Re: [PATCH 23/30] microblaze_mmu_v1: Enable fork syscall for MMU and add fork as vfork for noMMU
Date: Wed, 29 Apr 2009 13:31:26 +0200
User-Agent: KMail/1.9.9
Cc: John Williams <john.williams@petalogix.com>, linux-kernel@vger.kernel.org
References: <1240821139-7247-1-git-send-email-monstr@monstr.eu> <1d3f23370904270443u4ef547b3hab25b65babe329f3@mail.gmail.com> <49F82911.6060207@monstr.eu>
In-Reply-To: <49F82911.6060207@monstr.eu>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Message-Id: <200904291331.27043.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1043
Lines: 29

On Wednesday 29 April 2009, Michal Simek wrote:
> >> +sys_fork_wrapper:
> >> ?sys_vfork_wrapper:
> >> ? ? ? ?brid ? ?sys_vfork
> >> ? ? ? ?addk ? ?r5, r1, r0
> > 
> > NACK! ?If only it was that easy :)
> > 
> > On noMMU we cannot just silently call vfork() if the application tries
> > to fork() - you have to return -ENOSYS (or is there a better one?).
> > This will just require a small sys_fork_wrapper in entry-nommu.S.
> 
> I will call for noMMU kernel ni_syscall which solve that problem.
> (Arnd do it in his patches too)
> 

Note that my patches did not call the wrappers correctly, this
has to be fixed to make them work first.

For the fork call on !CONFIG_MMU, we should probably just add
a cond_syscall() in kernel/sys_ni.c near sys_msync() and
the other MMU specific calls.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/