Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763388AbZD2Wpf (ORCPT ); Wed, 29 Apr 2009 18:45:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761489AbZD2WlT (ORCPT ); Wed, 29 Apr 2009 18:41:19 -0400 Received: from exprod6og101.obsmtp.com ([64.18.1.181]:33248 "HELO exprod6og101.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1761194AbZD2WlS convert rfc822-to-8bit (ORCPT ); Wed, 29 Apr 2009 18:41:18 -0400 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Subject: Q: about struct task_struct Date: Wed, 29 Apr 2009 18:41:15 -0400 Message-ID: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: Q: about struct task_struct Thread-Index: AcnJG5qpoPFwCEF4QU+LP9LwFYJzZg== From: "H Hartley Sweeten" To: X-OriginalArrivalTime: 29 Apr 2009 22:41:16.0485 (UTC) FILETIME=[9B604F50:01C9C91B] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 841 Lines: 26 Hello all, In struct task_struck, should set_child_tid and clear_child_tid be int __user * or u32 __user *? In include/linux/sched.h they are both int __user * but in kernel/fork.c there is the following line: u32 __user * tidptr = tsk->clear_child_tid; This is causing a sparse warning: warning: incorrect type in initializer (different signedness) expected unsigned int [noderef] [usertype] *tidptr got int [noderef] *clear_child_tid It seems the struct should have them as u32 __user * since the clone_flags are defined up to 0x80000000 (CLONE_IO). Thanks, Hartley -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/