Date: Thu, 30 Apr 2009 12:01:00 +0200
From: Borislav Petkov <borislav.petkov@amd.com>
To: Ingo Molnar <mingo@elte.hu>
CC: Andrew Morton <akpm@linux-foundation.org>, torvalds@linux-foundation.org,
       greg@kroah.com, tglx@linutronix.de, hpa@zytor.com,
       dougthompson@xmission.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 13/21] amd64_edac: add f10-and-later methods-p3
Message-ID: <20090430100100.GB20167@aftab>
References: <1241024107-14535-1-git-send-email-borislav.petkov@amd.com> <1241024107-14535-14-git-send-email-borislav.petkov@amd.com> <20090429182255.GD8321@elte.hu> <20090429120501.ae005dc4.akpm@linux-foundation.org> <20090429192326.GA14652@elte.hu> <20090429124228.8677d4eb.akpm@linux-foundation.org> <20090429195357.GB17021@elte.hu> <20090429204730.GA24298@elte.hu>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
In-Reply-To: <20090429204730.GA24298@elte.hu>
User-Agent: Mutt/1.5.18 (2008-05-17)
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1415
Lines: 39

Hi,

On Wed, Apr 29, 2009 at 10:47:30PM +0200, Ingo Molnar wrote:

[..]

> What i point out below is precisely what you say is ineligible 
> under:
> 
> > > Of course, we don't have to use StinkyIdentifiers anywhere else.  
> 
> I'd extend that rule to say that StinkyIdentifiers should only be 
> used for hw API definitions/constants - macros, enums - not really 
> local variable names. The moment they are allowed into local 
> variables the stuff below happens.

to agree with Andrew, at a certain point in time I thought that having
the same register bit names as in the docs would be preferential when
you look at the docs and what the code does. But Ingo's also quite
right: we can't have "normal kernel coding style" and StinkyIdentifiers
:) in the same source file.

/me locking himself back in the patch creation basement.

-- 
Regards/Gruss,
Boris.

Operating | Advanced Micro Devices GmbH
  System  | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. M?nchen, Germany
 Research | Gesch?ftsf?hrer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni
  Center  | Sitz: Dornach, Gemeinde Aschheim, Landkreis M?nchen
  (OSRC)  | Registergericht M?nchen, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/