Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762953AbZD3OZu (ORCPT ); Thu, 30 Apr 2009 10:25:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761492AbZD3OZk (ORCPT ); Thu, 30 Apr 2009 10:25:40 -0400 Received: from smtp.ultrahosting.com ([74.213.174.254]:46552 "EHLO smtp.ultrahosting.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757745AbZD3OZj (ORCPT ); Thu, 30 Apr 2009 10:25:39 -0400 Date: Thu, 30 Apr 2009 10:15:58 -0400 (EDT) From: Christoph Lameter X-X-Sender: cl@qirst.com To: Ingo Molnar cc: Mathieu Desnoyers , Linus Torvalds , Andrew Morton , Nick Piggin , KOSAKI Motohiro , Peter Zijlstra , thomas.pi@arcor.dea, Yuriy Lalym , Linux Kernel Mailing List , ltt-dev@lists.casi.polymtl.ca, Tejun Heo Subject: Re: [PATCH] Fix dirty page accounting in redirty_page_for_writepage() In-Reply-To: <20090430141446.GD14696@elte.hu> Message-ID: References: <20090429232546.GB15782@Krystal> <20090430024303.GB19875@Krystal> <20090430133859.GB8329@elte.hu> <20090430141446.GD14696@elte.hu> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 644 Lines: 17 On Thu, 30 Apr 2009, Ingo Molnar wrote: > The patch below makes the fallback/slowpath irq safe. Yes but sometimes you are already irq safe and such a fallback would create significant irq/enable/disable stack operations etc overhead for architectures that are using the fallback. I think we really need another __xxx op here. Especially since these operations are often in critical code paths. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/